You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2026/04/09 02:52:19 UTC
[PR] CI: add smoke test for command validation [cloudberry-backup]
tuhaihe opened a new pull request, #84:
URL: https://github.com/apache/cloudberry-backup/pull/84
Add smoke test to verify all cloudberry-backup commands (gpbackup, gprestore, gpbackup_helper, gpbackup_s3_plugin, gpbackman) can be built, installed to GPHOME, and executed with --version and --help flags.
This provides fast feedback on basic functionality before running more expensive integration tests.
<!--Thank you for contributing! -->
<!--In case of an existing issue or discussions, please reference it-->
closes: #ISSUE_Number
<!--Remove this section if no corresponding issue.-->
---
## Change logs
> Describe your change clearly, including what problem is being solved or what document is being added or updated.
## Contributor's checklist
Here are some reminders before you submit your pull request:
* Make sure that your Pull Request has a clear title and commit message. You can take the [Git commit template](https://github.com/apache/cloudberry/blob/main/.gitmessage) as a reference.
* Learn the [code contribution](https://cloudberry.apache.org/contribute/code) and [doc contribution](https://cloudberry.apache.org/contribute/doc) guides for better collaboration.
* Make sure that CICD workflow is successful.
* List your communications in the [GitHub Issues](https://github.com/apache/cloudberry-backup/issues) or [Discussions](https://github.com/apache/cloudberry/discussions) (if has or needed).
* Feel free to ask for the [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) or other people to help review and approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] CI: add smoke test for command validation [cloudberry-backup]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84#discussion_r3057235754
##########
.github/workflows/cloudberry-backup-ci.yml:
##########
@@ -316,6 +316,25 @@ jobs:
set +e
case "${TEST_TARGET}" in
+ smoke)
Review Comment:
Ok, let me resolve this comment. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] CI: add smoke test for command validation [cloudberry-backup]
Posted by "woblerr (via GitHub)" <gi...@apache.org>.
woblerr commented on code in PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84#discussion_r3057220316
##########
.github/workflows/cloudberry-backup-ci.yml:
##########
@@ -316,6 +316,25 @@ jobs:
set +e
case "${TEST_TARGET}" in
+ smoke)
Review Comment:
Thanks, it's resolved.
For some reason, I can't resolve the thread, an error occurs: `Failed to resolve thread`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] CI: add smoke test for command validation [cloudberry-backup]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84#discussion_r3056680542
##########
.github/workflows/cloudberry-backup-ci.yml:
##########
@@ -316,6 +316,25 @@ jobs:
set +e
case "${TEST_TARGET}" in
+ smoke)
Review Comment:
Good catch! I've added `set -e` at the beginning of the smoke test case to re-enable error exit. This ensures that any failed command will cause the test to fail immediately and won't print "All smoke tests passed" incorrectly.
See 10ef2e0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] CI: add smoke test for command validation [cloudberry-backup]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] CI: add smoke test for command validation [cloudberry-backup]
Posted by "woblerr (via GitHub)" <gi...@apache.org>.
woblerr commented on code in PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84#discussion_r3056165501
##########
.github/workflows/cloudberry-backup-ci.yml:
##########
@@ -316,6 +316,25 @@ jobs:
set +e
case "${TEST_TARGET}" in
+ smoke)
Review Comment:
It looks like, if any of the `--version` or `--help` commands fail, the shell just keeps going and happily prints "All smoke tests passed".
In line 317 there is `set +x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org