You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2009/09/17 14:13:55 UTC
svn commit: r816161 - in
/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server:
POP3Handler.java POP3HandlerChain.java POP3Session.java
Author: rdonkin
Date: Thu Sep 17 12:13:55 2009
New Revision: 816161
URL: http://svn.apache.org/viewvc?rev=816161&view=rev
Log:
Remove unused API methods
Modified:
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3HandlerChain.java
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java
Modified: james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java?rev=816161&r1=816160&r2=816161&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java (original)
+++ james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java Thu Sep 17 12:13:55 2009
@@ -21,25 +21,24 @@
package org.apache.james.pop3server;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+
import org.apache.avalon.framework.container.ContainerUtil;
import org.apache.commons.logging.Log;
import org.apache.james.Constants;
import org.apache.james.core.MailImpl;
import org.apache.james.services.MailRepository;
import org.apache.james.socket.CRLFTerminatedReader;
-import org.apache.james.socket.ProtocolHandler;
import org.apache.james.socket.ProtocolContext;
+import org.apache.james.socket.ProtocolHandler;
import org.apache.james.socket.Watchdog;
import org.apache.mailet.Mail;
-import java.io.IOException;
-import java.io.OutputStream;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Locale;
-
/**
* The handler class for POP3 connections.
*
@@ -142,15 +141,6 @@
/**
- * The hash map that holds variables for the POP3 message transfer in progress.
- *
- * This hash map should only be used to store variable set in a particular
- * set of sequential MAIL-RCPT-DATA commands, as described in RFC 2821. Per
- * connection values should be stored as member variables in this class.
- */
- private HashMap state = new HashMap();
-
- /**
* The user name of the authenticated user associated with this POP3 transaction.
*/
private String authenticatedUser;
@@ -175,7 +165,6 @@
authenticatedUser = "unknown";
sessionEnded = false;
- resetState();
// Initially greet the connector
// Format is: Sat, 24 Jan 1998 13:16:09 -0500
@@ -358,20 +347,6 @@
}
/**
- * @see org.apache.james.pop3server.POP3Session#resetState()
- */
- public void resetState() {
- state.clear();
- }
-
- /**
- * @see org.apache.james.pop3server.POP3Session#getState()
- */
- public HashMap getState() {
- return state;
- }
-
- /**
* @see org.apache.james.pop3server.POP3Session#getUser()
*/
public String getUser() {
Modified: james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3HandlerChain.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3HandlerChain.java?rev=816161&r1=816160&r2=816161&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3HandlerChain.java (original)
+++ james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3HandlerChain.java Thu Sep 17 12:13:55 2009
@@ -53,7 +53,6 @@
private Log log = FALLBACK_LOG;
private Map<String, List<CommandHandler>> commandHandlerMap = new HashMap<String, List<CommandHandler>>();
- private ArrayList messageHandlers = new ArrayList();
private List<ConnectHandler> connectHandlers = new ArrayList<ConnectHandler>();
private final CommandHandler unknownHandler = new UnknownCmdHandler();
@@ -225,15 +224,6 @@
}
/**
- * Returns all the configured message handlers
- *
- * @return List of message handlers
- */
- List getMessageHandlers() {
- return messageHandlers;
- }
-
- /**
* Returns all the configured connect handlers
*
* @return List of connect handlers
Modified: james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java?rev=816161&r1=816160&r2=816161&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java (original)
+++ james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java Thu Sep 17 12:13:55 2009
@@ -22,16 +22,15 @@
package org.apache.james.pop3server;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.List;
+
import org.apache.commons.logging.Log;
import org.apache.james.services.MailRepository;
import org.apache.james.socket.Watchdog;
import org.apache.mailet.Mail;
-import java.io.IOException;
-import java.io.OutputStream;
-import java.util.HashMap;
-import java.util.List;
-
/**
* All the handlers access this interface to communicate with
* POP3Handler object
@@ -103,19 +102,6 @@
boolean isSessionEnded();
/**
- * Returns Map that consists of the state of the POP3Session
- *
- * @return map of the current POP3Session state
- */
- HashMap getState();
-
- /**
- * Resets message-specific, but not authenticated user, state.
- *
- */
- void resetState();
-
- /**
* Returns POP3Handler service wide configuration
*
* @return POP3HandlerConfigurationData
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org