You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/20 12:59:14 UTC

[GitHub] [maven] michael-o commented on a diff in pull request #758: [MNG-7504] Don't print warning unsupported reportPlugins for m-site-p

michael-o commented on code in PR #758:
URL: https://github.com/apache/maven/pull/758#discussion_r901635390


##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##########
@@ -151,28 +151,42 @@ private void checkUnknownMojoConfigurationParameters( MojoExecution mojoExecutio
 
         unknownParameters = getUnknownParameters( mojoExecution, parametersNamesAll );
 
-        unknownParameters.forEach(
-            name ->
-            {
-                MessageBuilder messageBuilder = MessageUtils.buffer()
-                    .warning( "Parameter '" )
-                    .warning( name )
-                    .warning( "' is unknown for plugin '" )
-                    .warning( mojoExecution.getArtifactId() ).warning( ":" )
-                    .warning( mojoExecution.getVersion() ).warning( ":" )
-                    .warning( mojoExecution.getGoal() );
-
-                if ( mojoExecution.getExecutionId() != null )
+        unknownParameters.stream()
+            .filter( parameterName -> isNotReportPluginsForMavenSite( parameterName, mojoExecution ) )
+            .forEach(

Review Comment:
   Insane! I love lambdas!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org