You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "arcolight (via GitHub)" <gi...@apache.org> on 2025/11/27 10:31:05 UTC
[PR] IGNITE-27136 C++ 3.0: Fix memory leak in the ignite-odbc-test [ignite-3]
arcolight opened a new pull request, #7096:
URL: https://github.com/apache/ignite-3/pull/7096
https://issues.apache.org/jira/browse/IGNITE-27136
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27136 C++ 3.0: Fix memory leak in the ignite-odbc-test [ignite-3]
Posted by "arcolight (via GitHub)" <gi...@apache.org>.
arcolight commented on code in PR #7096:
URL: https://github.com/apache/ignite-3/pull/7096#discussion_r2568148333
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
Makes sense, removed
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
+
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw_last_secure_error(on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27136 C++ 3.0: Fix memory leak in the ignite-odbc-test [ignite-3]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7096:
URL: https://github.com/apache/ignite-3/pull/7096#discussion_r2568129204
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
+
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw_last_secure_error(on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
This assertion is redundant because it appears immediately after a conditional throw statement. If the code reaches this line, `ssl` is guaranteed to be non-null. Consider removing this redundant assertion along with the one on line 54.
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
This assertion is redundant because it appears immediately after a conditional throw statement. If the code reaches this line, `ssl` is guaranteed to be non-null. The same issue exists on line 64. Consider removing both redundant assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27136 C++ 3.0: Fix memory leak in the ignite-odbc-test [ignite-3]
Posted by "isapego (via GitHub)" <gi...@apache.org>.
isapego merged PR #7096:
URL: https://github.com/apache/ignite-3/pull/7096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org