You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Fanyi (Jira)" <ji...@apache.org> on 2022/04/11 12:03:00 UTC
[jira] [Commented] (CXF-8690) Refactor org.apache.cxf.common.util package
[ https://issues.apache.org/jira/browse/CXF-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520527#comment-17520527 ]
Fanyi commented on CXF-8690:
----------------------------
[~reta] Could you help me review this issue?
> Refactor org.apache.cxf.common.util package
> --------------------------------------------
>
> Key: CXF-8690
> URL: https://issues.apache.org/jira/browse/CXF-8690
> Project: CXF
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Fanyi
> Priority: Major
> Fix For: 3.5.2
>
> Attachments: CXF-CachedClass-java.png, CXF-XmlSchemaPrimitiveUtils-java.png
>
>
> *Issue Description*
> Package *__ _org.apache.cxf.common.util_* __ is a promiscuous package, and groups together miscellaneous functionalities that might be useful to different subsystems. This means the cohesion between classes in the package is low. However, since the project has grown larger, this package structure is becoming increasingly hard to navigate. We found that Class _*CachedClass*_ and *_XmlSchemaPrimitiveUtils_* is not used by classes in their package _{*}org.apache.cxf.common.util{*}._ Moreover, there are dependencies between the above two classes and other packages.
> Location: The source file can be found at path File /core/src/main/java/org/apache/cxf/common/util/CachedClass.java
> /core/src/main/java/org/apache/cxf/common/util/XmlSchemaPrimitiveUtils.java
>
> *Refactoring suggestions*
>
> To avoid making *_org.apache.cxf.common.util_* too big and unmanageable, we suggest to move class *_CachedClass_* into package \{_}*org.apache.cxf.common.jaxb*{_},and move class *_XmlSchemaPrimitiveUtils_* into package *{_}org.apache.cxf.jaxrs.model.wadl{_}.*
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)