You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/06/24 00:42:36 UTC
[GitHub] [mynewt-core] ncasaril opened a new pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
ncasaril opened a new pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629
Due to way MYNEWT_VAL is defined (always within ()) some preprocesor
magic is required when passing comma separated values.
Heavily Inspired by #2628 but using preprocessor magic to initialise the original vector instead.
Tested with 0, 1, and multiple pins redirected to networking core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril merged pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
ncasaril merged pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-867536995
yeah, bitmap would be cleaner solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-870512046
@ncasaril yeap, I'd go with your original solution.
In long term we can think about extending newt tool to have support for 'set' or 'list' type of sysvals...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-870132013
@sjanc, I don't think there are that many people using this yet so we could still go back to the magic if everyone agrees?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-867354337
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-870512046
@ncasaril yeap, I'd go with your original solution.
In long term we can think about extending newt tool to have support for 'set' or 'list' type of sysvals...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-869598307
although this is already merged, after looking at how user needs to define it now... I think the previous macro-magic was nicer solution...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-867400497
do we really want to relay on code injection and macro magic to handle this? why not just define bitmask for pins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-868120922
Now using a bitmask instead of the preprocessor magic. Also updated syscfg comment to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-870933574
New PR created where the original, non bitmask, solution is used: #2637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ncasaril commented on pull request #2629: hw/ipc_nrf5340: Fix enabling multiple GPIOs passed to network core
Posted by GitBox <gi...@apache.org>.
ncasaril commented on pull request #2629:
URL: https://github.com/apache/mynewt-core/pull/2629#issuecomment-870132013
@sjanc, I don't think there are that many people using this yet so we could still go back to the magic if everyone agrees?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org