You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/07 19:57:49 UTC

[GitHub] [lucene-solr] madrob commented on a change in pull request #2136: SOLR-15037: fix prevent config change listener to reload core while s…

madrob commented on a change in pull request #2136:
URL: https://github.com/apache/lucene-solr/pull/2136#discussion_r553454573



##########
File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java
##########
@@ -454,8 +459,8 @@ private ManagedIndexSchema getFreshManagedSchema(SolrCore core) throws IOExcepti
       if (in instanceof ZkSolrResourceLoader.ZkByteArrayInputStream) {
         int version = ((ZkSolrResourceLoader.ZkByteArrayInputStream) in).getStat().getVersion();
         log.info("managed schema loaded . version : {} ", version);
-        return new ManagedIndexSchema(core.getSolrConfig(), name, new InputSource(in), true, name, version,
-            core.getLatestSchema().getSchemaUpdateLock());
+        Lock schemaLock = (Lock) core.getLatestSchema().getSchemaUpdateLock();

Review comment:
       redundant cast




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org