[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #964: [KYUUBI #956] Fail to get table list if there is _ in schema's name

[GitBox <gi...@apache.org>]

pan3793 edited a comment on pull request #964:
URL: https://github.com/apache/incubator-kyuubi/pull/964#issuecomment-902509070


   > > can we add a test then for `if there is _ in schema's name` ?
   > 
   > Sure, after some check, it seems the best place to add this test is in "get schemas" of BasicJDBCTests.scala.
   > 
   > it will be included in the following 5 final test suites:
   > 
   > * KyuubiOperationHiveCatalogSuite
   > * KyuubiOperationPerServerSuite
   > * KyuubiOperationPerUserSuite
   > * KyuubiStatementMonitorSuite
   > * SparkOperationSuite
   > 
   > Without my fix, but with my unit test change, the first 3 suite still success, but the last 2 will fail. (haven't got time to learn what is different between first 3 suites with the last 2 suites)
   > 
   > After my fix, for the new unit test change, all 5 suites will success.
   
   The first 3 suites are `jdbc-client` ==> `kyuubi-server` ==> `kyuubi-spark-engine`.
   The later 2 suites are `jdbc-client` ==> `kyuubi-spark-engine`.
   
   Seems somethings happens in `kyuubi-server` when passing through the request, like remove escape chars.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org