[GitHub] [spark] LuciferYang commented on a change in pull request #35567: [WIP][SPARK-38175][CORE][FOLLOWUP] Clean up unused parameters in private methods signature

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #35567:
URL: https://github.com/apache/spark/pull/35567#discussion_r809730677



##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryAppStatusStore.scala
##########
@@ -45,20 +45,20 @@ private[spark] class HistoryAppStatusStore(
   override def executorList(activeOnly: Boolean): Seq[v1.ExecutorSummary] = {
     val execList = super.executorList(activeOnly)
     logUrlPattern match {
-      case Some(pattern) => execList.map(replaceLogUrls(_, pattern))
+      case Some(_) => execList.map(replaceLogUrls)
       case None => execList
     }
   }
 
   override def executorSummary(executorId: String): v1.ExecutorSummary = {
     val execSummary = super.executorSummary(executorId)
     logUrlPattern match {
-      case Some(pattern) => replaceLogUrls(execSummary, pattern)
+      case Some(_) => replaceLogUrls(execSummary)
       case None => execSummary
     }
   }
 
-  private def replaceLogUrls(exec: v1.ExecutorSummary, urlPattern: String): v1.ExecutorSummary = {

Review comment:
       [SPARK-26311](https://issues.apache.org/jira/browse/SPARK-26311) defines this method with `urlPattern` and after SPARK-26792, change to use `logUrlPattern` held by `ExecutorLogUrlHandler`
   
   
   
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org