[GitHub] [arrow] pitrou commented on a diff in pull request #12914: ARROW-2034: [C++] Filesystem implementation for Azure Blob Storage

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #12914:
URL: https://github.com/apache/arrow/pull/12914#discussion_r884930370


##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -37,6 +37,34 @@ if(ARROW_GCS)
                  Boost::system)
 endif()
 
+if(ARROW_AZURE)
+  set(AZURE_SRCS)
+  list(APPEND
+        AZURE_SRCS
+        azurefs_mock.cc
+        azurefs.cc)
+
+  add_arrow_lib(azurefs
+                SOURCES
+                ${AZURE_SRCS}
+                SHARED_LINK_LIBS
+                ${ARROW_LINK_LIBS}
+                SHARED_PRIVATE_LINK_LIBS
+                ${ARROW_SHARED_PRIVATE_LINK_LIBS}
+                STATIC_LINK_LIBS
+                ${ARROW_STATIC_LINK_LIBS})
+
+  set_target_properties(azurefs_objlib PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON)

Review Comment:
   Right. Also, `.h` files should not use any C++14 features either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org