You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/15 04:07:21 UTC

[GitHub] [airflow] edithturn opened a new pull request, #23714: Kind Cluster on Breeze

edithturn opened a new pull request, #23714:
URL: https://github.com/apache/airflow/pull/23714

   Migrating ./breeze legacy kind-cluster [commands] to breeze.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1126855428

   @potiuk thank you for your feedback, I was creating the group with click and not with "main" that was my mistake.  This is how it is looking now.
   
   ![Screenshot from 2022-05-14 23-10-23](https://user-images.githubusercontent.com/58795858/168456834-fa39721e-5179-4397-a950-a0ec104d0e1a.png)
   ![Screenshot from 2022-05-14 23-10-15](https://user-images.githubusercontent.com/58795858/168456836-8e11a64b-7772-4957-a09b-cc4e31e2cffe.png)
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1145867731

   Yep. Looks right. And yes we can add utils for those - though those are pretty "localised" and likely there is no need to create separate "utils" for them - they would be better in "kind" command python file. We can always move them to "utils" when we find other use for them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1139224179

   Some conflicts to solve :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1163246909

   I keep this draft for a long time. @potiuk is taking it with a different approach. I'm closing this draft. :/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1139225435

   😥  let me try to solve them, Jarek!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn closed pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
edithturn closed pull request #23714: Kind Cluster on Breeze
URL: https://github.com/apache/airflow/pull/23714


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edithturn commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1145557022

   @potiuk I was checking /breeze-legacy kind-cluster start
   Let me know if all these steps are correct for "start" for ./breeze
   
   1. Validate Docker Version
   2. Starts KinD cluster include:
   2.1. Pull the latest version of Apache Airflow for a kind cluster: ghcr.io/apache/airflow/main/ci/python3.7:latest
   2.1. Checking resources (Memory, CPUs, and Disk)
   2.3. Downloading Kind version v0.14.0
   2.4. Downloading Kubectl version v1.24.0
   2.5. Downloading Helm version v3.6.3
   2.6. Creating a cluster of kind
   
   Some functions are already created like Checking resources, and for the others, I'm thinking of a utils file to add the download, helm, kubectl functions, unless they already exist elsewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23714: Kind Cluster on Breeze

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23714:
URL: https://github.com/apache/airflow/pull/23714#issuecomment-1129179585

   Yep. That's better - you need to rebase though and re-run pre-commits as some of the images generated do not take into account latest changes in rich.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org