RE: Proposed Bug fixes for org/apache/xalan/templates/OutputPrope rtie s.java

[Patrick Moore <pa...@rioport.com>]

Hi Scott --

If I send diffs using the unix diff format is that o.k.? (can CVS import
that way?) Or should I install cvs just to do the diffs.

Other answers below.

-Pat 
> 
> In loadPropertiesFile, you have a System.err.println.  Is 
> there any reason
> I can't change this to a throw new WrappedRuntimeException?
> 

If there was a default properties then I was letting the processing
continue.
(Obviously there is the possibility that this would cause more confusion.)

> > 4. Problem: the double-check locking mechanism does not 
> work in Java (see
> > bug #919)
> 
> Hmm... worrisome  The issue about not being able to rely on a 
> boolean flag
> is more problematic, as we use a similar technique in the 
> stree module to
> coordinate between the parser and the transformation without 
> synchronizing.
> If we have to start synchronizing all over the place, I 
> wonder what the
> penalty will be?
> 

Ugliness --- I know. I just can't believe that this kind of problem exists
at all.

> > 1. Problem: HTML output method does not uses XML output 
> properties as
> > default.
> > In the code this is not true for html. This
> > is now changed to match the comments
> 
> I don't see where the difference is in the code?
> 
> 
> What am I missing??

Nothing.. It looks like it got changed after I got my copy of the code.

> 
> > 3. Problem: the streams were not closed after reading the 
> property file.
> 
> Yup.  Thanks.
>