You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kristynsmith (via GitHub)" <gi...@apache.org> on 2025/08/26 14:08:04 UTC
[PR] Fix typos [beam]
kristynsmith opened a new pull request, #35958:
URL: https://github.com/apache/beam/pull/35958
Fix typos from https://github.com/apache/beam/pull/35656
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos and update test implementation from #35656 [beam]
Posted by "kristynsmith (via GitHub)" <gi...@apache.org>.
kristynsmith commented on code in PR #35958:
URL: https://github.com/apache/beam/pull/35958#discussion_r2301986605
##########
sdks/python/apache_beam/internal/code_object_pickler_test.py:
##########
@@ -126,83 +126,76 @@ def get_lambda_from_dictionary():
return get_lambda_from_dictionary()
+prefix = (
+ "__main__" if __name__ == "__main__" else
Review Comment:
1. when these tests are run in google3, prefix is `__main__`. i want the code here and in google3 to be as similar as possible, so i added this prefix part so the code paths can be correct while still having the same code in both places.
2. i thought hardcoding made it more clear, but i see the benefit in doing it programmatically. i've updated it accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos and update test implementation from #35656 [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #35958:
URL: https://github.com/apache/beam/pull/35958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos and update test implementation from #35656 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35958:
URL: https://github.com/apache/beam/pull/35958#issuecomment-3225390800
Assigning reviewers:
R: @tvalentyn for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typos and update test implementation from #35656 [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #35958:
URL: https://github.com/apache/beam/pull/35958#discussion_r2301963768
##########
sdks/python/apache_beam/internal/code_object_pickler_test.py:
##########
@@ -126,83 +126,76 @@ def get_lambda_from_dictionary():
return get_lambda_from_dictionary()
+prefix = (
+ "__main__" if __name__ == "__main__" else
Review Comment:
1) in which case prefix is `__main__`
2) does it make sense to determine `prefix` programmatically instead of hardcoding the values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org