You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/08 08:03:55 UTC
[GitHub] [flink] zhoulii opened a new pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
zhoulii opened a new pull request #12849:
URL: https://github.com/apache/flink/pull/12849
## What is the purpose of the change
remove redundant null value judgment for 'clusterId' in KubernetesSessionCli#run
## Brief change log
- remove redundant null value judgment for 'clusterId'
## Verifying this change
- This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655374125
Hi, @zhoulii . I think this check is not redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655360746
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ccc81507bc17cf68f4aef4e53ad883c1c5b4b116 (Wed Jul 08 08:06:50 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655374196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ccc81507bc17cf68f4aef4e53ad883c1c5b4b116",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4326",
"triggerID" : "ccc81507bc17cf68f4aef4e53ad883c1c5b4b116",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccc81507bc17cf68f4aef4e53ad883c1c5b4b116 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4326)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhoulii closed pull request #12849: [hotfix][k8s] remove redundant null value check for 'clusterId'
Posted by GitBox <gi...@apache.org>.
zhoulii closed pull request #12849:
URL: https://github.com/apache/flink/pull/12849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655374196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ccc81507bc17cf68f4aef4e53ad883c1c5b4b116",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccc81507bc17cf68f4aef4e53ad883c1c5b4b116",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccc81507bc17cf68f4aef4e53ad883c1c5b4b116 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhoulii commented on pull request #12849: [hotfix][k8s] remove redundant null value judgment for 'clusterId'
Posted by GitBox <gi...@apache.org>.
zhoulii commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655387112
`final ClusterDescriptor<String> kubernetesClusterDescriptor =
kubernetesClusterClientFactory.createClusterDescriptor(configuration);`
above code will create **KubernetesClusterDescriptor**, and in [KubernetesClusterDescriptor construct method](https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java#L79) ，we already check the value of clusterId, if clusterId value is null，a NullPointerException will be thrown.
so, when execute code `if (clusterId != null && kubeClient.getRestService(clusterId).isPresent())` ，clusterId must not be null @KarmaGYZ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #12849: [hotfix][k8s] remove redundant null value check for 'clusterId'
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655402235
@zhoulii Yes, you're right. However, I don't think it is a contract of `KubernetesClusterClientFactory#createClusterDescriptor`. Thus it is not stable. I still think it would be good to keep this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhoulii commented on pull request #12849: [hotfix][k8s] remove redundant null value check for 'clusterId'
Posted by GitBox <gi...@apache.org>.
zhoulii commented on pull request #12849:
URL: https://github.com/apache/flink/pull/12849#issuecomment-655458469
@KarmaGYZ I see, thanks for explanation, i will close this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org