You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commonsrdf.apache.org by Benedikt Ritter <br...@apache.org> on 2015/04/03 20:27:13 UTC

Tabs vs. spaces

Hi,

although at Commons every project may chose it's own code style, we have
one rule: no tabs.
I know this is somehow a religious discussion, but that is what we have
agreed upon.
When looking at the RDF code, I can see that pom.xml is intended using
spaces, but the Java code uses tabs.
Would you be willing to use spaces instead?

Thanks and regards,
Benedikt

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: Tabs vs. spaces

Posted by Gary Gregory <ga...@gmail.com>.
+1 to spaces, no tabs.

G

On Fri, Apr 3, 2015 at 11:27 AM, Benedikt Ritter <br...@apache.org> wrote:

> Hi,
>
> although at Commons every project may chose it's own code style, we have
> one rule: no tabs.
> I know this is somehow a religious discussion, but that is what we have
> agreed upon.
> When looking at the RDF code, I can see that pom.xml is intended using
> spaces, but the Java code uses tabs.
> Would you be willing to use spaces instead?
>
> Thanks and regards,
> Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: Tabs vs. spaces

Posted by Sergio Fernández <wi...@apache.org>.
Benedikt is right, we have a mix of both formatting styles.

I've just committed a quick code reformatting, but as Peter suggested we
may need to adopt something more specified and supported by our tool chain:
https://maven.apache.org/developers/conventions/code.html



On Fri, Apr 3, 2015 at 11:55 PM, Peter Ansell <an...@gmail.com>
wrote:

> Sure, do you have an eclipse formatting spec that we could use to
> automatically reformat Java files with?
>
>
>
> > On 4 Apr 2015, at 5:27 am, Benedikt Ritter <br...@apache.org> wrote:
> >
> > Hi,
> >
> > although at Commons every project may chose it's own code style, we have
> > one rule: no tabs.
> > I know this is somehow a religious discussion, but that is what we have
> > agreed upon.
> > When looking at the RDF code, I can see that pom.xml is intended using
> > spaces, but the Java code uses tabs.
> > Would you be willing to use spaces instead?
> >
> > Thanks and regards,
> > Benedikt
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>



-- 
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co

Re: Tabs vs. spaces

Posted by Stian Soiland-Reyes <st...@apache.org>.
+1 for (4?) spaces and an Eclipse reformatting.
 On 3 Apr 2015 22:56, "Peter Ansell" <an...@gmail.com> wrote:

> Sure, do you have an eclipse formatting spec that we could use to
> automatically reformat Java files with?
>
>
>
> > On 4 Apr 2015, at 5:27 am, Benedikt Ritter <br...@apache.org> wrote:
> >
> > Hi,
> >
> > although at Commons every project may chose it's own code style, we have
> > one rule: no tabs.
> > I know this is somehow a religious discussion, but that is what we have
> > agreed upon.
> > When looking at the RDF code, I can see that pom.xml is intended using
> > spaces, but the Java code uses tabs.
> > Would you be willing to use spaces instead?
> >
> > Thanks and regards,
> > Benedikt
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>

Re: Tabs vs. spaces

Posted by Peter Ansell <an...@gmail.com>.
Sure, do you have an eclipse formatting spec that we could use to automatically reformat Java files with?



> On 4 Apr 2015, at 5:27 am, Benedikt Ritter <br...@apache.org> wrote:
> 
> Hi,
> 
> although at Commons every project may chose it's own code style, we have
> one rule: no tabs.
> I know this is somehow a religious discussion, but that is what we have
> agreed upon.
> When looking at the RDF code, I can see that pom.xml is intended using
> spaces, but the Java code uses tabs.
> Would you be willing to use spaces instead?
> 
> Thanks and regards,
> Benedikt
> 
> -- 
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter