You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/04/19 07:09:32 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #594: fix(go/adbc/driver/flightsql): use updated authorization header from server
lidavidm opened a new pull request, #594:
URL: https://github.com/apache/arrow-adbc/pull/594
Fixes #584.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #594: fix(go/adbc/driver/flightsql): use updated authorization header from server
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #594:
URL: https://github.com/apache/arrow-adbc/pull/594#issuecomment-1514931552
@lidavidm I think you're right. That whole `if isHdrs` branch should probably be removed from that block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #594: fix(go/adbc/driver/flightsql): use updated authorization header from server
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #594:
URL: https://github.com/apache/arrow-adbc/pull/594#issuecomment-1514305402
@zeroshade something looks suspect to me. It's crashing here:
https://github.com/apache/arrow/blob/85f67cd22d21ea1225e94a32398f730f2e0d6807/go/arrow/flight/client.go#L124
Isn't `cs` always invalid since we're in an `err != nil` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #594: fix(go/adbc/driver/flightsql): use updated authorization header from server
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #594:
URL: https://github.com/apache/arrow-adbc/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org