[jira] [Commented] (TEZ-2369) Add a few unit tests for RootInputInitializerManager

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512262#comment-14512262 ] 

TezQA commented on TEZ-2369:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12728126/TEZ-2369.1.txt
  against master revision 2935ef4.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 170 javac compiler warnings (more than the master's current 160 warnings).

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/538//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/538//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/538//console

This message is automatically generated.

> Add a few unit tests for RootInputInitializerManager
> ----------------------------------------------------
>
>                 Key: TEZ-2369
>                 URL: https://issues.apache.org/jira/browse/TEZ-2369
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-2369.1.txt
>
>
> {code}
> -      Integer successfulAttempt = vertexSuccessfulAttemptMap.get(taskId);
> +      Integer successfulAttempt = vertexSuccessfulAttemptMap.get(taskId.getId());
> {code}
> This could cause events to be sent multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)