You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/17 22:45:32 UTC

Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-11824
    https://issues.apache.org/jira/browse/AMBARI-11824


Repository: ambari


Description
-------

Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  

The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 

Diff: https://reviews.apache.org/r/35579/diff/


Testing
-------

Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.

Updated case in existing unit tests.

mvn clean test

all tests pass


Thanks,

Tom Beerbower


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/#review88357
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On June 17, 2015, 6:17 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35579/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 6:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-11824
>     https://issues.apache.org/jira/browse/AMBARI-11824
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  
> 
> The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 
> 
> Diff: https://reviews.apache.org/r/35579/diff/
> 
> 
> Testing
> -------
> 
> Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.
> 
> Updated case in existing unit tests.
> 
> mvn clean test
> 
> all tests pass
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49:38 min
> [INFO] Finished at: 2015-06-17T18:16:15-04:00
> [INFO] Final Memory: 55M/1623M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/#review88445
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On June 18, 2015, 6:25 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35579/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:25 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-11824
>     https://issues.apache.org/jira/browse/AMBARI-11824
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  
> 
> The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 
> 
> Diff: https://reviews.apache.org/r/35579/diff/
> 
> 
> Testing
> -------
> 
> Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.
> 
> Updated case in existing unit tests.
> 
> mvn clean test
> 
> all tests pass
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49:38 min
> [INFO] Finished at: 2015-06-17T18:16:15-04:00
> [INFO] Final Memory: 55M/1623M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/#review88466
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On June 18, 2015, 6:25 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35579/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 6:25 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-11824
>     https://issues.apache.org/jira/browse/AMBARI-11824
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  
> 
> The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 
> 
> Diff: https://reviews.apache.org/r/35579/diff/
> 
> 
> Testing
> -------
> 
> Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.
> 
> Updated case in existing unit tests.
> 
> mvn clean test
> 
> all tests pass
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49:38 min
> [INFO] Finished at: 2015-06-17T18:16:15-04:00
> [INFO] Final Memory: 55M/1623M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/
-----------------------------------------------------------

(Updated June 18, 2015, 10:25 p.m.)


Review request for Ambari, Nate Cole and Robert Levas.


Changes
-------

Reopened because of failing unit test.  Updated diff.


Bugs: AMBARI-11824
    https://issues.apache.org/jira/browse/AMBARI-11824


Repository: ambari


Description
-------

Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  

The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 

Diff: https://reviews.apache.org/r/35579/diff/


Testing
-------

Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.

Updated case in existing unit tests.

mvn clean test

all tests pass

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:38 min
[INFO] Finished at: 2015-06-17T18:16:15-04:00
[INFO] Final Memory: 55M/1623M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/#review88305
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On June 17, 2015, 6:17 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35579/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 6:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-11824
>     https://issues.apache.org/jira/browse/AMBARI-11824
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  
> 
> The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 
> 
> Diff: https://reviews.apache.org/r/35579/diff/
> 
> 
> Testing
> -------
> 
> Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.
> 
> Updated case in existing unit tests.
> 
> mvn clean test
> 
> all tests pass
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 49:38 min
> [INFO] Finished at: 2015-06-17T18:16:15-04:00
> [INFO] Final Memory: 55M/1623M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 35579: Views: Tez View should automatically work out of the box in Ambari 2.1

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35579/
-----------------------------------------------------------

(Updated June 17, 2015, 10:17 p.m.)


Review request for Ambari, Nate Cole and Robert Levas.


Changes
-------

update test results to include build success output


Bugs: AMBARI-11824
    https://issues.apache.org/jira/browse/AMBARI-11824


Repository: ambari


Description
-------

Set the tez-site/tez.tez-ui.history-url.base property for the stack advisor when a cluster is being created.  

The URL value should be constructed based on the latest TEZ view that has been deployed in Ambari (based on view version).


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py d65d711 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2f73f18 

Diff: https://reviews.apache.org/r/35579/diff/


Testing (updated)
-------

Manual tested to verify that the stack advisor property is correctly set and that the URL value that is generated correctly points to the UI for the deployed TEZ view.

Updated case in existing unit tests.

mvn clean test

all tests pass

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:38 min
[INFO] Finished at: 2015-06-17T18:16:15-04:00
[INFO] Final Memory: 55M/1623M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower