You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/17 12:37:44 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #6388: Introduce log analysis language (LAL)
kezhenxu94 opened a new pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #6264.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.19%`.
> The diff coverage is `45.60%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.53% +21.19%
- Complexity 2152 3694 +1542
=============================================
Files 1010 1789 +779
Lines 24536 38095 +13559
Branches 2405 4205 +1800
=============================================
+ Hits 7201 19253 +12052
- Misses 16817 17851 +1034
- Partials 518 991 +473
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `11.76% <11.76%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [1381 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580111149
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
Review comment:
Example is fine, but moving them to `/config-examples` seems a better idea, including the previous `alarm-settings-sample.yml` file, what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `14.30%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 43.65% +14.30%
- Complexity 2152 2666 +514
=============================================
Files 1010 848 -162
Lines 24536 20925 -3611
Branches 2405 1983 -422
=============================================
+ Hits 7201 9134 +1933
+ Misses 16817 11097 -5720
- Partials 518 694 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [311 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `23.08%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.43% +23.08%
- Complexity 2152 3772 +1620
=============================================
Files 1010 999 -11
Lines 24536 24617 +81
Branches 2405 2413 +8
=============================================
+ Hits 7201 12907 +5706
+ Misses 16817 10589 -6228
- Partials 518 1121 +603
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [409 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579628612
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
Review comment:
I am feeling whether we should keep example in the release, or doc folder only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578199084
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
Review comment:
> That is a wrong direction. MetricsCreator you pointed, is using the OAP to measure metrics. If you take a closer look, you will see, we need OTEL or Prometheus fetcher to read the data back to MAL.
> Instead, you should take a look how OC-receiver and Zabbix-receiver works, transfer the data into `SampleFamily`.
Make sense to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `14.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 38.47% -14.81%
+ Complexity 3934 2334 -1600
=============================================
Files 1767 825 -942
Lines 37687 20422 -17265
Branches 4172 1947 -2225
=============================================
- Hits 20081 7858 -12223
+ Misses 16612 11950 -4662
+ Partials 994 614 -380
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1376 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578227896
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
Review comment:
You missed `timestamp` in the list of `Extractor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.48%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.16% +21.48%
- Complexity 2385 3896 +1511
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13337 +5262
+ Misses 16037 10154 -5883
- Partials 599 1132 +533
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.05%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.73% +17.05%
- Complexity 2385 3665 +1280
=============================================
Files 1011 999 -12
Lines 24711 24574 -137
Branches 2439 2403 -36
=============================================
+ Hits 8075 12222 +4147
+ Misses 16037 11308 -4729
- Partials 599 1044 +445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-784110333
> > Do we really have default LAL script?
>
> Turns out we need a default LAL to save the logs, which is the default behavior of 8.4.0
Ha, we missed this. Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `7.05%`.
> The diff coverage is `4.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 36.40% +7.05%
- Complexity 2152 2246 +94
============================================
Files 1010 831 -179
Lines 24536 20438 -4098
Branches 2405 1931 -474
============================================
+ Hits 7201 7441 +240
+ Misses 16817 12442 -4375
- Partials 518 555 +37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.02%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.37% +25.02%
- Complexity 2152 3923 +1771
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13435 +6234
+ Misses 16817 10122 -6695
- Partials 518 1150 +632
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `10.46%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 43.14% +10.46%
- Complexity 2385 2634 +249
=============================================
Files 1011 848 -163
Lines 24711 20834 -3877
Branches 2439 1987 -452
=============================================
+ Hits 8075 8988 +913
+ Misses 16037 11174 -4863
- Partials 599 672 +73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [311 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577661435
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
Review comment:
We could require `LogData`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577620320
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
Review comment:
JSON = JavaScript Object Notation, should be upper case all the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578198867
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ tid parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `tid`
Review comment:
> Trace id should not be enough, the segment id and span should be provided too.
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `14.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 36.05% -14.41%
+ Complexity 3687 2175 -1512
=============================================
Files 1769 808 -961
Lines 37797 19990 -17807
Branches 4156 1913 -2243
=============================================
- Hits 19073 7208 -11865
+ Misses 17740 12235 -5505
+ Partials 984 547 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.55%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.90% +21.55%
- Complexity 2152 3684 +1532
=============================================
Files 1010 999 -11
Lines 24536 24576 +40
Branches 2405 2408 +3
=============================================
+ Hits 7201 12511 +5310
+ Misses 16817 10986 -5831
- Partials 518 1079 +561
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [386 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b921bba) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `7.18%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 39.86% +7.18%
- Complexity 2385 2407 +22
============================================
Files 1011 831 -180
Lines 24711 20276 -4435
Branches 2439 1911 -528
============================================
+ Hits 8075 8083 +8
+ Misses 16037 11564 -4473
- Partials 599 629 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `16.90%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 46.25% +16.90%
- Complexity 2152 2810 +658
=============================================
Files 1010 848 -162
Lines 24536 20958 -3578
Branches 2405 2001 -404
=============================================
+ Hits 7201 9694 +2493
+ Misses 16817 10523 -6294
- Partials 518 741 +223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [363 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `7.89%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 40.57% +7.89%
- Complexity 2385 2526 +141
============================================
Files 1011 848 -163
Lines 24711 20822 -3889
Branches 2439 1971 -468
============================================
+ Hits 8075 8448 +373
+ Misses 16037 11751 -4286
- Partials 599 623 +24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [307 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `17.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 35.72% -17.56%
+ Complexity 3934 2141 -1793
=============================================
Files 1767 808 -959
Lines 37687 19903 -17784
Branches 4172 1905 -2267
=============================================
- Hits 20081 7111 -12970
+ Misses 16612 12252 -4360
+ Partials 994 540 -454
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1395 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b9af649) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `21.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 29.35% -21.12%
=============================================
Files 1769 1668 -101
Lines 37797 34984 -2813
Branches 4156 4621 +465
=============================================
- Hits 19073 10268 -8805
- Misses 17740 23765 +6025
+ Partials 984 951 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/oap/server/core/source/Endpoint.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmModule.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1Nb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/oap/server/core/config/ConfigService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29uZmlnL0NvbmZpZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [826 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `14.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 35.97% -14.49%
+ Complexity 3687 2167 -1520
=============================================
Files 1769 808 -961
Lines 37797 19990 -17807
Branches 4156 1913 -2243
=============================================
- Hits 19073 7192 -11881
+ Misses 17740 12249 -5491
+ Partials 984 549 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-782590186
> There is minor adjustments in the docs, please take an overall view of it before reviewing codes
@kezhenxu94 If you intend the reviewer to check the minor change, please don't do force push, because it is hard to find the difference :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (4c7e55c) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `3.36%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 29.31% -3.37%
============================================
Files 1011 1683 +672
Lines 24711 35253 +10542
Branches 2439 4641 +2202
============================================
+ Hits 8075 10335 +2260
- Misses 16037 23955 +7918
- Partials 599 963 +364
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1712 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...6fc30e7](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579647524
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
Why Sample's labels changeable now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-782592238
> > There is minor adjustments in the docs, please take an overall view of it before reviewing codes
>
> @kezhenxu94 If you intend the reviewer to check the minor change, please don't do force push, because it is hard to find the difference :)
Indeed that's a good point, will take care next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `16.00%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 45.35% +16.00%
- Complexity 2152 2755 +603
=============================================
Files 1010 848 -162
Lines 24536 20955 -3581
Branches 2405 2001 -404
=============================================
+ Hits 7201 9504 +2303
+ Misses 16817 10719 -6098
- Partials 518 732 +214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579671151
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
Copy makes sense to me. I just don't want any further PR(not yours) adding same dynamic label mechanism but missed by the PMC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (2920cb0) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `5.90%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 35.25% +5.90%
- Complexity 2152 2186 +34
============================================
Files 1010 831 -179
Lines 24536 20303 -4233
Branches 2405 1920 -485
============================================
- Hits 7201 7157 -44
+ Misses 16817 12605 -4212
- Partials 518 541 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `23.42%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.77% +23.42%
- Complexity 2152 3845 +1693
=============================================
Files 1010 999 -11
Lines 24536 24690 +154
Branches 2405 2418 +13
=============================================
+ Hits 7201 13029 +5828
+ Misses 16817 10529 -6288
- Partials 518 1132 +614
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [455 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.39%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.07% +15.39%
- Complexity 2385 3520 +1135
=============================================
Files 1011 998 -13
Lines 24711 24500 -211
Branches 2439 2380 -59
=============================================
+ Hits 8075 11778 +3703
+ Misses 16037 11733 -4304
- Partials 599 989 +390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `8.09%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 40.77% +8.09%
- Complexity 2385 2482 +97
============================================
Files 1011 831 -180
Lines 24711 20318 -4393
Branches 2439 1918 -521
============================================
+ Hits 8075 8285 +210
+ Misses 16037 11416 -4621
- Partials 599 617 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `23.55%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.90% +23.55%
- Complexity 2152 3854 +1702
=============================================
Files 1010 999 -11
Lines 24536 24690 +154
Branches 2405 2418 +13
=============================================
+ Hits 7201 13062 +5861
+ Misses 16817 10496 -6321
- Partials 518 1132 +614
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [458 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.88%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.23% +25.88%
- Complexity 2152 3986 +1834
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13665 +6464
+ Misses 16817 9879 -6938
- Partials 518 1195 +677
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [462 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `15.05%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 44.40% +15.05%
- Complexity 2152 2710 +558
=============================================
Files 1010 848 -162
Lines 24536 20925 -3611
Branches 2405 1983 -422
=============================================
+ Hits 7201 9292 +2091
+ Misses 16817 10927 -5890
- Partials 518 706 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (1fd5144) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `3.49%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 29.18% -3.50%
============================================
Files 1011 1691 +680
Lines 24711 35417 +10706
Branches 2439 4662 +2223
============================================
+ Hits 8075 10337 +2262
- Misses 16037 24118 +8081
- Partials 599 962 +363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1710 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577657594
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
Review comment:
> This comment is not very accurate. The JSON and YAML format data don't have to be from `LogData`, especially not have to be gRPC reported.
The reported method may be not gRPC indeed, but I suppose the reported data is of type `LogData` always, even if they're integrated from third-party systems, IMO they should be adapted to the SkyWalking's (unified) data structure (`LogData` it is).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `20.16%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 52.84% +20.16%
- Complexity 2385 3822 +1437
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13012 +4937
+ Misses 16037 10498 -5539
- Partials 599 1113 +514
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [421 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `4.09%`.
> The diff coverage is `24.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 33.44% +4.09%
- Complexity 2152 2542 +390
============================================
Files 1010 980 -30
Lines 24536 23763 -773
Branches 2405 2295 -110
============================================
+ Hits 7201 7947 +746
+ Misses 16817 15121 -1696
- Partials 518 695 +177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-6.00)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.81% <0.00%> (-53.19%)` | `0.00 <0.00> (-7.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [400 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `9.60%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 42.28% +9.60%
- Complexity 2385 2598 +213
============================================
Files 1011 848 -163
Lines 24711 20834 -3877
Branches 2439 1987 -452
============================================
+ Hits 8075 8809 +734
+ Misses 16037 11370 -4667
- Partials 599 655 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [302 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b921bba](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578227332
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
Review comment:
Could we use `parsed.*` as tag's `key`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `9.61%`.
> The diff coverage is `24.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 38.96% +9.61%
- Complexity 2152 3004 +852
============================================
Files 1010 997 -13
Lines 24536 24417 -119
Branches 2405 2378 -27
============================================
+ Hits 7201 9513 +2312
+ Misses 16817 14079 -2738
- Partials 518 825 +307
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-6.00)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.81% <0.00%> (-53.19%)` | `0.00 <0.00> (-7.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `2.64%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 30.03% -2.65%
+ Complexity 2385 1896 -489
============================================
Files 1011 830 -181
Lines 24711 20104 -4607
Branches 2439 1855 -584
============================================
- Hits 8075 6038 -2037
+ Misses 16037 13610 -2427
+ Partials 599 456 -143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [483 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `22.32%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 55.00% +22.32%
- Complexity 2385 3953 +1568
=============================================
Files 1011 999 -12
Lines 24711 24648 -63
Branches 2439 2410 -29
=============================================
+ Hits 8075 13557 +5482
+ Misses 16037 9959 -6078
- Partials 599 1132 +533
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [422 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b921bba](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `2.78%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 32.13% +2.78%
+ Complexity 2152 1997 -155
============================================
Files 1010 831 -179
Lines 24536 20264 -4272
Branches 2405 1900 -505
============================================
- Hits 7201 6512 -689
+ Misses 16817 13288 -3529
+ Partials 518 464 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [295 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `11.90%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 41.25% +11.90%
- Complexity 2152 2565 +413
=============================================
Files 1010 848 -162
Lines 24536 20918 -3618
Branches 2405 1983 -422
=============================================
+ Hits 7201 8630 +1429
+ Misses 16817 11628 -5189
- Partials 518 660 +142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577712966
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
+ tags:
+ ["key1": "value1", "key2": "value2"]
+ }
+ }
+ gauge { // whenever the filter is fed with a piece of log, the gauge will be increased by one
+ name: "whatever"
+ tips: "whatever"
+ tags: ["k1": "v1", "k2": "v2"]
+ }
+ histogram {
+ name: "httpRequestTime"
+ tips: "The time elapsed of the http request"
+ startNanos: parsed["timestamp"]
+ duration: parsed["duration"]
+ }
+ }
+ }
+ // ...
+}
+```
+
+### Sink
+
+Sinks are the persistent layer of the LAL. By default, all the logs of each filter are persisted into the storage. However, there are some mechanisms that allow you to selectively save some logs, or even drop all the logs after you've extracted useful information, such as metrics.
+
+#### Sampler
+
+Sampler allows you to save the logs in a sampling manner. Currently, 2 sampling strategies are supported, `ratelimit` and `probabilistic`.
+
+`ratelimit` samples `n` logs at most, in a given duration (e.g. 1 second).
+`probabilistic` samples `n%` logs .
+
+Examples:
+
+```groovy
+filter {
+ // ... parser
+
+ sampler {
Review comment:
What happens if I put 2 samplers here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `8.90%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 38.25% +8.90%
- Complexity 2152 2345 +193
============================================
Files 1010 831 -179
Lines 24536 20463 -4073
Branches 2405 1934 -471
============================================
+ Hits 7201 7828 +627
+ Misses 16817 12065 -4752
- Partials 518 570 +52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [394 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577707955
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
+ tags:
+ ["key1": "value1", "key2": "value2"]
+ }
+ }
+ gauge { // whenever the filter is fed with a piece of log, the gauge will be increased by one
+ name: "whatever"
+ tips: "whatever"
+ tags: ["k1": "v1", "k2": "v2"]
+ }
+ histogram {
+ name: "httpRequestTime"
+ tips: "The time elapsed of the http request"
+ startNanos: parsed["timestamp"]
Review comment:
`timestamp` is required by `Sample`. And timestamp is required by all types of metrics.
All metrics generated in one LAL scripts, should be as a SampleFamily, to be the input of the MAL core. Then, users should be able to set the MAL script to do further analysis. Then closed loop is set.
If MAL is still not clear to you, ping me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577711631
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
Review comment:
`parse, extract, filter, analyze, and save` VS `parser, extractor, and sink`. It makes me feel a little inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.71%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.38% +21.71%
- Complexity 2385 3925 +1540
=============================================
Files 1011 999 -12
Lines 24711 24648 -63
Branches 2439 2410 -29
=============================================
+ Hits 8075 13406 +5331
+ Misses 16037 10110 -5927
- Partials 599 1132 +533
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [421 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b921bba](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.65%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.33% +21.65%
- Complexity 2385 3900 +1515
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13379 +5304
+ Misses 16037 10103 -5934
- Partials 599 1141 +542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [416 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `22.68%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.03% +22.68%
- Complexity 2152 3803 +1651
=============================================
Files 1010 998 -12
Lines 24536 24645 +109
Branches 2405 2414 +9
=============================================
+ Hits 7201 12823 +5622
+ Misses 16817 10729 -6088
- Partials 518 1093 +575
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [451 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `12.33%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 41.68% +12.33%
- Complexity 2152 3086 +934
=============================================
Files 1010 981 -29
Lines 24536 24036 -500
Branches 2405 2337 -68
=============================================
+ Hits 7201 10019 +2818
+ Misses 16817 13171 -3646
- Partials 518 846 +328
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578228584
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
Review comment:
Where should user activate the MAL script? Is this in the log-analyzer? Or some places else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.36%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 50.04% +17.36%
- Complexity 2385 3677 +1292
=============================================
Files 1011 999 -12
Lines 24711 24574 -137
Branches 2439 2403 -36
=============================================
+ Hits 8075 12298 +4223
+ Misses 16037 11208 -4829
- Partials 599 1068 +469
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.20%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 49.55% +20.20%
- Complexity 2152 2962 +810
=============================================
Files 1010 848 -162
Lines 24536 21006 -3530
Branches 2405 2003 -402
=============================================
+ Hits 7201 10410 +3209
+ Misses 16817 9748 -7069
- Partials 518 848 +330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [388 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `23.14%`.
> The diff coverage is `6.23%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.49% +23.14%
- Complexity 2152 3982 +1830
=============================================
Files 1010 1789 +779
Lines 24536 38169 +13633
Branches 2405 4217 +1812
=============================================
+ Hits 7201 20035 +12834
- Misses 16817 17130 +313
- Partials 518 1004 +486
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1423 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-783369692
I notice, there is no e2e for the LAL, consider to adding through another PR? And do we have/need empty `lal` and `log-mal-rules` folders?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `14.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 35.96% -14.50%
+ Complexity 3687 2166 -1521
=============================================
Files 1769 808 -961
Lines 37797 19990 -17807
Branches 4156 1913 -2243
=============================================
- Hits 19073 7190 -11883
+ Misses 17740 12250 -5490
+ Partials 984 550 -434
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578959012
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,293 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id,
+segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+The LAL config files are in YAML format, and are located under directory `lal`, you can
+set `log-analyzer/default/lalFiles` in the `application.yml` file or set environment variable `SW_LOG_LAL_FILES` to
+activate specific LAL config files.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log
+sent into the filter is available as property `log` in the LAL, therefore you can access the log service name
+via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag level: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if not
+dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if not
+dropped) and is used to associate with traces / metrics.
+
+- `timestamp`
+
+`timestamp` extracts the timestamp from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `tag`
+
+`tag` extracts the tags from the `parsed` result, and set them into the `LogData`. The form of this extractor is
+something like `tag key1: value, key2: value2`, you can use the properties of `parsed` as both keys and values.
+
+```groovy
+filter {
+ // ... parser
+
+ extractor {
+ tag level: parsed.level, (parsed.statusCode): parsed.statusMsg
+ tag anotherKey: "anotherConstantValue"
+ }
+}
+```
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can
+configure [MAL](mal.md) for further analysis of these metrics. The dedicated MAL config files are under
+directory `log-mal-rules`, you can set `log-analyzer/default/malFiles` to enable configured files.
+
+```yaml
+# application.yml
+# ...
+log-analyzer:
+ selector: ${SW_LOG_ANALYZER:default}
+ default:
+ lalFiles: ${SW_LOG_LAL_FILES:my-lal-config.yaml} # files are under "lal" directory
+ malFiles: ${SW_LOG_MAL_FILES:my-lal-mal-config.yaml,another-lal-mal-config.yaml} # files are under "log-mal-rules" directory
Review comment:
Then it is a meter system issue, we should not include suffix there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `17.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 35.73% -17.55%
+ Complexity 3934 2142 -1792
=============================================
Files 1767 808 -959
Lines 37687 19904 -17783
Branches 4172 1907 -2265
=============================================
- Hits 20081 7113 -12968
+ Misses 16612 12251 -4361
+ Partials 994 540 -454
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1395 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `23.14%`.
> The diff coverage is `6.23%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.49% +23.14%
- Complexity 2152 3982 +1830
=============================================
Files 1010 1789 +779
Lines 24536 38169 +13633
Branches 2405 4217 +1812
=============================================
+ Hits 7201 20035 +12834
- Misses 16817 17130 +313
- Partials 518 1004 +486
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1423 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.46%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.14% +15.46%
- Complexity 2385 3507 +1122
=============================================
Files 1011 999 -12
Lines 24711 24488 -223
Branches 2439 2395 -44
=============================================
+ Hits 8075 11789 +3714
+ Misses 16037 11705 -4332
- Partials 599 994 +395
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `7.22%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 39.90% +7.22%
- Complexity 2385 2434 +49
============================================
Files 1011 831 -180
Lines 24711 20318 -4393
Branches 2439 1918 -521
============================================
+ Hits 8075 8107 +32
+ Misses 16037 11596 -4441
- Partials 599 615 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [308 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.61%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.29% +21.61%
- Complexity 2385 3899 +1514
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13368 +5293
+ Misses 16037 10115 -5922
- Partials 599 1140 +541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [415 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `16.09%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.77% +16.09%
- Complexity 2385 3532 +1147
=============================================
Files 1011 999 -12
Lines 24711 24488 -223
Branches 2439 2395 -44
=============================================
+ Hits 8075 11943 +3868
+ Misses 16037 11543 -4494
- Partials 599 1002 +403
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `28.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 57.59% +28.24%
+ Complexity 2152 804 -1348
=============================================
Files 1010 170 -840
Lines 24536 4134 -20402
Branches 2405 478 -1927
=============================================
- Hits 7201 2381 -4820
+ Misses 16817 1450 -15367
+ Partials 518 303 -215
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...e/skywalking/oap/server/core/oal/rt/OALDefine.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTERlZmluZS5qYXZh) | | | |
| [...erver/library/module/ApplicationConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL0FwcGxpY2F0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | | | |
| [...age/plugin/elasticsearch/base/TimeSeriesUtils.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lU2VyaWVzVXRpbHMuamF2YQ==) | | | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | | | |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | | | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | | | |
| [...ap/server/exporter/provider/grpc/GRPCExporter.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyLmphdmE=) | | | |
| ... and [979 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `19.70%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 52.38% +19.70%
- Complexity 2385 3794 +1409
=============================================
Files 1011 999 -12
Lines 24711 24610 -101
Branches 2439 2404 -35
=============================================
+ Hits 8075 12891 +4816
+ Misses 16037 10618 -5419
- Partials 599 1101 +502
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [412 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `19.49%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 48.83% +19.49%
- Complexity 2152 3591 +1439
=============================================
Files 1010 998 -12
Lines 24536 24603 +67
Branches 2405 2411 +6
=============================================
+ Hits 7201 12016 +4815
+ Misses 16817 11575 -5242
- Partials 518 1012 +494
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.81%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.16% +25.81%
- Complexity 2152 3965 +1813
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13630 +6429
+ Misses 16817 9908 -6909
- Partials 518 1169 +651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [475 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.42%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 49.77% +20.42%
- Complexity 2152 3631 +1479
=============================================
Files 1010 998 -12
Lines 24536 24613 +77
Branches 2405 2412 +7
=============================================
+ Hits 7201 12250 +5049
+ Misses 16817 11326 -5491
- Partials 518 1037 +519
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `19.99%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 52.66% +19.99%
- Complexity 2385 3822 +1437
=============================================
Files 1011 999 -12
Lines 24711 24637 -74
Branches 2439 2392 -47
=============================================
+ Hits 8075 12976 +4901
+ Misses 16037 10558 -5479
- Partials 599 1103 +504
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [392 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b921bba](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577681909
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
Review comment:
That is a wrong direction. MetricsCreator you pointed, is using the OAP to measure metrics. If you take a closer look, you will see, we need OTEL or Prometheus fetcher to read the data back to MAL.
Instead, you should take a look how OC-receiver and Zabbix-receiver works, transfer the data into `SampleFamily`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/6d92bc66ddded41cff37efc8155e23b17d814dcb?el=desc) (6d92bc6) will **decrease** coverage by `8.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 53.65% 45.39% -8.27%
+ Complexity 3984 3288 -696
============================================
Files 1766 975 -791
Lines 37678 24003 -13675
Branches 4179 2349 -1830
============================================
- Hits 20216 10895 -9321
+ Misses 16458 12171 -4287
+ Partials 1004 937 -67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [6c6a8a7...71a9da0](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `22.55%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 51.90% +22.55%
- Complexity 2152 3058 +906
=============================================
Files 1010 848 -162
Lines 24536 21006 -3530
Branches 2405 2003 -402
=============================================
+ Hits 7201 10903 +3702
+ Misses 16817 9228 -7589
- Partials 518 875 +357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [412 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `8.67%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 38.02% +8.67%
- Complexity 2152 2370 +218
============================================
Files 1010 848 -162
Lines 24536 20857 -3679
Branches 2405 1978 -427
============================================
+ Hits 7201 7930 +729
+ Misses 16817 12343 -4474
- Partials 518 584 +66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580857801
##########
File path: dist-material/config-examples/lal.yaml
##########
@@ -18,8 +18,13 @@ rules:
- name: example
dsl: |
filter {
+ if (log.service == "TestService") {
+ abort {}
+ }
text {
- regexp $/(?s)(?<timestamp>\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d{3}) \[TID:(?<tid>.+?)] \[(?<thread>.+?)] (?<level>\w{4,}) (?<logger>.{1,36}) (?<msg>.+)/$
+ if (!regexp($/(?s)(?<timestamp>\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d{3}) \[TID:(?<tid>.+?)] \[(?<thread>.+?)] (?<level>\w{4,}) (?<logger>.{1,36}) (?<msg>.+)/$)) {
+ abort {}
Review comment:
Interesting, like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (3cc9edf) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `7.95%`.
> The diff coverage is `4.24%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 37.30% +7.95%
+ Complexity 2152 1761 -391
============================================
Files 1010 1776 +766
Lines 24536 37701 +13165
Branches 2405 4364 +1959
============================================
+ Hits 7201 14065 +6864
- Misses 16817 22638 +5821
- Partials 518 998 +480
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1393 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.34%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 49.69% +20.34%
- Complexity 2152 3615 +1463
=============================================
Files 1010 999 -11
Lines 24536 24576 +40
Branches 2405 2408 +3
=============================================
+ Hits 7201 12212 +5011
+ Misses 16817 11310 -5507
- Partials 518 1054 +536
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [374 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `7.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 53.28% 45.39% -7.90%
+ Complexity 3934 3288 -646
============================================
Files 1767 975 -792
Lines 37687 24003 -13684
Branches 4172 2349 -1823
============================================
- Hits 20081 10895 -9186
+ Misses 16612 12171 -4441
+ Partials 994 937 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `10.01%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 42.69% +10.01%
- Complexity 2385 2592 +207
=============================================
Files 1011 831 -180
Lines 24711 20468 -4243
Branches 2439 1927 -512
=============================================
+ Hits 8075 8739 +664
+ Misses 16037 11037 -5000
- Partials 599 692 +93
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.16%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.51% +25.16%
- Complexity 2152 3907 +1755
=============================================
Files 1010 999 -11
Lines 24536 24623 +87
Branches 2405 2404 -1
=============================================
+ Hits 7201 13423 +6222
+ Misses 16817 10050 -6767
- Partials 518 1150 +632
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [460 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...0ef3a36](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.66%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.34% +15.66%
- Complexity 2385 3547 +1162
=============================================
Files 1011 999 -12
Lines 24711 24556 -155
Branches 2439 2402 -37
=============================================
+ Hits 8075 11872 +3797
+ Misses 16037 11686 -4351
- Partials 599 998 +399
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [356 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `10.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 42.45% -10.83%
+ Complexity 3934 2535 -1399
=============================================
Files 1767 825 -942
Lines 37687 20431 -17256
Branches 4172 1947 -2225
=============================================
- Hits 20081 8674 -11407
+ Misses 16612 11097 -5515
+ Partials 994 660 -334
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `14.84%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 47.52% +14.84%
- Complexity 2385 3485 +1100
=============================================
Files 1011 998 -13
Lines 24711 24500 -211
Branches 2439 2380 -59
=============================================
+ Hits 8075 11644 +3569
+ Misses 16037 11876 -4161
- Partials 599 980 +381
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577646392
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
Review comment:
This comment is not very accurate. The JSON and YAML format data don't have to be from `LogData`, especially not have to be gRPC reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577642207
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
Review comment:
Note that log.level does not exist in the protocol; it is a dynamic field in TAG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `14.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 36.04% -14.42%
+ Complexity 3687 2174 -1513
=============================================
Files 1769 808 -961
Lines 37797 19990 -17807
Branches 4156 1913 -2243
=============================================
- Hits 19073 7206 -11867
+ Misses 17740 12236 -5504
+ Partials 984 548 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579668845
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
Also, use `ImmutableMap` as the type doesn't allow use to use `Collections.unmodifiableMap()` to wrap the map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `0.01%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 32.65% -0.02%
+ Complexity 2385 2019 -366
============================================
Files 1011 831 -180
Lines 24711 20245 -4466
Branches 2439 1890 -549
============================================
- Hits 8075 6612 -1463
+ Misses 16037 13168 -2869
+ Partials 599 465 -134
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580121155
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+ - name: example
+ dsl: |
+ filter {
Review comment:
Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577637195
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ tid parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `tid`
+
+`tid` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
Review comment:
How to get the value for counter/gauge or even more complex histogram(bucket required)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `22.92%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 52.27% +22.92%
- Complexity 2152 3813 +1661
=============================================
Files 1010 998 -12
Lines 24536 24645 +109
Branches 2405 2414 +9
=============================================
+ Hits 7201 12884 +5683
+ Misses 16817 10654 -6163
- Partials 518 1107 +589
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [453 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `8.25%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 24.41% -8.26%
+ Complexity 2385 1552 -833
============================================
Files 1011 830 -181
Lines 24711 20055 -4656
Branches 2439 1850 -589
============================================
- Hits 8075 4897 -3178
+ Misses 16037 14822 -1215
+ Partials 599 336 -263
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [448 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.45%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 50.13% +17.45%
- Complexity 2385 3591 +1206
=============================================
Files 1011 999 -12
Lines 24711 24498 -213
Branches 2439 2396 -43
=============================================
+ Hits 8075 12282 +4207
+ Misses 16037 11199 -4838
- Partials 599 1017 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.29%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 49.64% +20.29%
- Complexity 2152 3634 +1482
=============================================
Files 1010 998 -12
Lines 24536 24549 +13
Branches 2405 2388 -17
=============================================
+ Hits 7201 12188 +4987
+ Misses 16817 11332 -5485
- Partials 518 1029 +511
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `17.25%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 46.60% +17.25%
- Complexity 2152 3451 +1299
=============================================
Files 1010 998 -12
Lines 24536 24537 +1
Branches 2405 2388 -17
=============================================
+ Hits 7201 11435 +4234
+ Misses 16817 12143 -4674
- Partials 518 959 +441
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/6d92bc66ddded41cff37efc8155e23b17d814dcb?el=desc) (6d92bc6) will **decrease** coverage by `8.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 53.65% 45.39% -8.27%
+ Complexity 3984 3288 -696
============================================
Files 1766 975 -791
Lines 37678 24003 -13675
Branches 4179 2349 -1830
============================================
- Hits 20216 10895 -9321
+ Misses 16458 12171 -4287
+ Partials 1004 937 -67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [6c6a8a7...4c7e55c](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `6.40%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 35.75% +6.40%
- Complexity 2152 2231 +79
============================================
Files 1010 848 -162
Lines 24536 20777 -3759
Branches 2405 1953 -452
============================================
+ Hits 7201 7428 +227
+ Misses 16817 12819 -3998
- Partials 518 530 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [227 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579650705
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
If not really changeable, when have to change this? I think we should build a new `ImmutableMap` from a `Map`/`HashMap` in building Sample
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b9af649) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `23.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 29.35% -23.94%
=============================================
Files 1767 1668 -99
Lines 37687 34984 -2703
Branches 4172 4621 +449
=============================================
- Hits 20081 10268 -9813
- Misses 16612 23765 +7153
+ Partials 994 951 -43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oal/rt/output/AllDispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9BbGxEaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/server/core/source/Source.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...che/skywalking/oap/server/core/source/Service.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...che/skywalking/oap/server/core/source/SideCar.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NpZGVDYXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/oap/server/core/source/Endpoint.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmModule.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1Nb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/oap/server/core/config/ConfigService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY29uZmlnL0NvbmZpZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [825 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578379490
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
Review comment:
> Where should user activate the MAL script? Is this in the log-analyzer? Or some places else?
I think it's ok to put them in log-analyzer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577635462
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
Review comment:
> Speaking of the JSON and YAML, are they going to be flat structure? Such as using `level1.level2...` to represent the hierarchy?
It doesn't make things different in terms of usages, in LAL, they are nested objects under the hood, but you can still use `a.b.c` to access the nested properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `16.13%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 45.48% +16.13%
- Complexity 2152 2763 +611
=============================================
Files 1010 848 -162
Lines 24536 20955 -3581
Branches 2405 2001 -404
=============================================
+ Hits 7201 9531 +2330
+ Misses 16817 10693 -6124
- Partials 518 731 +213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [337 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `22.17%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 51.52% +22.17%
- Complexity 2152 3046 +894
=============================================
Files 1010 848 -162
Lines 24536 21006 -3530
Branches 2405 2003 -402
=============================================
+ Hits 7201 10824 +3623
+ Misses 16817 9325 -7492
- Partials 518 857 +339
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [410 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577632792
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
Review comment:
> Do we really have default LAL script?
I just removed that, the link will be pointed to the Envoy logs' config file after settled down
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.16%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.51% +25.16%
- Complexity 2152 3932 +1780
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13469 +6268
+ Misses 16817 10078 -6739
- Partials 518 1160 +642
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (2920cb0) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `10.14%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 39.49% +10.14%
- Complexity 2152 2954 +802
=============================================
Files 1010 982 -28
Lines 24536 23921 -615
Branches 2405 2327 -78
=============================================
+ Hits 7201 9448 +2247
+ Misses 16817 13644 -3173
- Partials 518 829 +311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.89%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.24% +20.89%
- Complexity 2152 3640 +1488
=============================================
Files 1010 999 -11
Lines 24536 24576 +40
Branches 2405 2408 +3
=============================================
+ Hits 7201 12347 +5146
+ Misses 16817 11161 -5656
- Partials 518 1068 +550
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [374 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `10.00%`.
> The diff coverage is `24.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 39.35% +10.00%
- Complexity 2152 3038 +886
=============================================
Files 1010 997 -13
Lines 24536 24417 -119
Branches 2405 2378 -27
=============================================
+ Hits 7201 9609 +2408
+ Misses 16817 13983 -2834
- Partials 518 825 +307
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-6.00)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.81% <0.00%> (-53.19%)` | `0.00 <0.00> (-7.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.82%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.49% +21.82%
- Complexity 2385 3906 +1521
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13419 +5344
+ Misses 16037 10054 -5983
- Partials 599 1150 +551
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [416 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `7.89%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 53.28% 45.39% -7.90%
+ Complexity 3934 3288 -646
============================================
Files 1767 975 -792
Lines 37687 24003 -13684
Branches 4172 2349 -1823
============================================
- Hits 20081 10895 -9186
+ Misses 16612 12171 -4441
+ Partials 994 937 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `24.76%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.11% +24.76%
- Complexity 2152 3910 +1758
=============================================
Files 1010 999 -11
Lines 24536 24635 +99
Branches 2405 2414 +9
=============================================
+ Hits 7201 13331 +6130
+ Misses 16817 10140 -6677
- Partials 518 1164 +646
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [445 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `13.54%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 42.89% +13.54%
- Complexity 2152 2647 +495
=============================================
Files 1010 848 -162
Lines 24536 20936 -3600
Branches 2405 2001 -404
=============================================
+ Hits 7201 8980 +1779
+ Misses 16817 11279 -5538
- Partials 518 677 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.19%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 47.87% +15.19%
- Complexity 2385 3513 +1128
=============================================
Files 1011 998 -13
Lines 24711 24500 -211
Branches 2439 2380 -59
=============================================
+ Hits 8075 11730 +3655
+ Misses 16037 11783 -4254
- Partials 599 987 +388
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781934395
This doc should be ready soon, do you plan to merge this first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `7.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 50.46% 43.22% -7.24%
+ Complexity 3687 3177 -510
============================================
Files 1769 976 -793
Lines 37797 24103 -13694
Branches 4156 2374 -1782
============================================
- Hits 19073 10419 -8654
+ Misses 17740 12805 -4935
+ Partials 984 879 -105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578392421
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
Review comment:
Let's make this clear in the documentation. Should this MAL script file be pointed in the LAL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.35%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 50.03% +17.35%
- Complexity 2385 3585 +1200
=============================================
Files 1011 999 -12
Lines 24711 24498 -213
Branches 2439 2396 -43
=============================================
+ Hits 8075 12257 +4182
+ Misses 16037 11224 -4813
- Partials 599 1017 +418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `1.68%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 56.20% 54.51% -1.69%
+ Complexity 4015 3907 -108
============================================
Files 1011 999 -12
Lines 24945 24623 -322
Branches 2473 2404 -69
============================================
- Hits 14020 13423 -597
- Misses 9697 10050 +353
+ Partials 1228 1150 -78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...e4127a6](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `8.30%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 40.98% +8.30%
- Complexity 2385 2553 +168
============================================
Files 1011 848 -163
Lines 24711 20822 -3889
Branches 2439 1971 -468
============================================
+ Hits 8075 8533 +458
+ Misses 16037 11659 -4378
- Partials 599 630 +31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577639340
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
Review comment:
> JSON = JavaScript Object Notation, should be upper case all the time.
do you prefer something like
```groovy
filter {
JSON {
}
// or
YAML {
}
}
```
over
```groovy
filter {
json {
}
// or
yaml {
}
}
```
?
I know the abbreviation of JSON and YAML, sometimes when they serve as field / method / file names, IMHO it's ok to lowercase them. However I can uppercase them if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577641853
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
Review comment:
Note that log.level does not exist in the protocol; it is a dynamic field in TAG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-784098797
> Do we really have default LAL script?
Turns out we need a default LAL to save the logs, which is the default behavior of 8.4.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `15.39%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 44.74% +15.39%
- Complexity 2152 2760 +608
=============================================
Files 1010 848 -162
Lines 24536 20934 -3602
Branches 2405 1998 -407
=============================================
+ Hits 7201 9367 +2166
+ Misses 16817 10846 -5971
- Partials 518 721 +203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.35%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.70% +25.35%
- Complexity 2152 3945 +1793
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13515 +6314
+ Misses 16817 10030 -6787
- Partials 518 1162 +644
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [475 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (2920cb0) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `5.56%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 34.91% +5.56%
- Complexity 2152 2153 +1
============================================
Files 1010 831 -179
Lines 24536 20294 -4242
Branches 2405 1920 -485
============================================
- Hits 7201 7085 -116
+ Misses 16817 12670 -4147
- Partials 518 539 +21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579650530
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
> Why Sample's labels changeable now?
Not changeable, just replace `ImmutableMap` with `Map` interface that can accept other type of `Map`, similar to `Map<xxx, xxx> a = new HashMap<>()` instead of `HashMap<xxx, xxx> a = new HashMap<>()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `3.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 50.46% 46.81% -3.66%
+ Complexity 3687 3386 -301
============================================
Files 1769 976 -793
Lines 37797 24103 -13694
Branches 4156 2374 -1782
============================================
- Hits 19073 11283 -7790
+ Misses 17740 11859 -5881
+ Partials 984 961 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...84d1260](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578955988
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,293 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id,
+segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+The LAL config files are in YAML format, and are located under directory `lal`, you can
+set `log-analyzer/default/lalFiles` in the `application.yml` file or set environment variable `SW_LOG_LAL_FILES` to
+activate specific LAL config files.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log
+sent into the filter is available as property `log` in the LAL, therefore you can access the log service name
+via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag level: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if not
+dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be persisted (if not
+dropped) and is used to associate with traces / metrics.
+
+- `timestamp`
+
+`timestamp` extracts the timestamp from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `tag`
+
+`tag` extracts the tags from the `parsed` result, and set them into the `LogData`. The form of this extractor is
+something like `tag key1: value, key2: value2`, you can use the properties of `parsed` as both keys and values.
+
+```groovy
+filter {
+ // ... parser
+
+ extractor {
+ tag level: parsed.level, (parsed.statusCode): parsed.statusMsg
+ tag anotherKey: "anotherConstantValue"
+ }
+}
+```
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can
+configure [MAL](mal.md) for further analysis of these metrics. The dedicated MAL config files are under
+directory `log-mal-rules`, you can set `log-analyzer/default/malFiles` to enable configured files.
+
+```yaml
+# application.yml
+# ...
+log-analyzer:
+ selector: ${SW_LOG_ANALYZER:default}
+ default:
+ lalFiles: ${SW_LOG_LAL_FILES:my-lal-config.yaml} # files are under "lal" directory
+ malFiles: ${SW_LOG_MAL_FILES:my-lal-mal-config.yaml,another-lal-mal-config.yaml} # files are under "log-mal-rules" directory
Review comment:
> The rule files are not including suffix, please recheck and keep consistent.
Actually they are inconsistent already, `spring-sleuth.yaml`, `self`, and `istio-controlplane`, which style should we adopt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.62%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.30% +15.62%
- Complexity 2385 3541 +1156
=============================================
Files 1011 999 -12
Lines 24711 24556 -155
Branches 2439 2402 -37
=============================================
+ Hits 8075 11862 +3787
+ Misses 16037 11696 -4341
- Partials 599 998 +399
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `8.73%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 38.08% +8.73%
- Complexity 2152 2307 +155
============================================
Files 1010 831 -179
Lines 24536 20241 -4295
Branches 2405 1893 -512
============================================
+ Hits 7201 7708 +507
+ Misses 16817 11955 -4862
- Partials 518 578 +60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580031477
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
Review comment:
> I am feeling an example in the doc with explanation line by line, should be more friendly.
From the perspective of an end user, I'll consider an example configuration in dist more friendly, users tend to copy-and-modify an existing example config file, instead of composing a new config file from scratch. This example file is not activated by default b/c we have activation rules config there. However, I don't strongly insist of this if you prefer to move it into the docs, the docs have snippets with explanations already though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781958009
> This doc should be ready soon, do you plan to merge this first?
No hurry. The doc should be adjusted (minor) as implemented. Will push codes and the adjusted doc together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `17.11%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 46.46% +17.11%
- Complexity 2152 2844 +692
=============================================
Files 1010 848 -162
Lines 24536 20993 -3543
Branches 2405 2003 -402
=============================================
+ Hits 7201 9755 +2554
+ Misses 16817 10477 -6340
- Partials 518 761 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `21.83%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 54.51% +21.83%
- Complexity 2385 3907 +1522
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13423 +5348
+ Misses 16037 10050 -5987
- Partials 599 1150 +551
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [416 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.79%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.14% +25.79%
- Complexity 2152 3983 +1831
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13643 +6442
+ Misses 16817 9908 -6909
- Partials 518 1188 +670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [461 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **decrease** coverage by `0.44%`.
> The diff coverage is `4.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 29.34% 28.90% -0.45%
+ Complexity 2152 1831 -321
============================================
Files 1010 830 -180
Lines 24536 20046 -4490
Branches 2405 1856 -549
============================================
- Hits 7201 5794 -1407
+ Misses 16817 13829 -2988
+ Partials 518 423 -95
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [433 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `1.90%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 34.58% +1.90%
+ Complexity 2385 2101 -284
============================================
Files 1011 831 -180
Lines 24711 20248 -4463
Branches 2439 1890 -549
============================================
- Hits 8075 7003 -1072
+ Misses 16037 12761 -3276
+ Partials 599 484 -115
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `1.68%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 56.20% 54.51% -1.69%
+ Complexity 4015 3907 -108
============================================
Files 1011 999 -12
Lines 24945 24623 -322
Branches 2473 2404 -69
============================================
- Hits 14020 13423 -597
- Misses 9697 10050 +353
+ Partials 1228 1150 -78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b2fe66e](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `20.79%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 53.47% +20.79%
- Complexity 2385 3847 +1462
=============================================
Files 1011 999 -12
Lines 24711 24623 -88
Branches 2439 2404 -35
=============================================
+ Hits 8075 13166 +5091
+ Misses 16037 10337 -5700
- Partials 599 1120 +521
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [421 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578087520
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
Review comment:
I think that is log collector or receiver responsibility, rather than LAL. Logic line identify is required before building Log structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `13.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 39.60% -13.68%
+ Complexity 3934 2378 -1556
=============================================
Files 1767 825 -942
Lines 37687 20442 -17245
Branches 4172 1964 -2208
=============================================
- Hits 20081 8097 -11984
+ Misses 16612 11737 -4875
+ Partials 994 608 -386
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-783354254
Once CI passed, update the changelog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.24%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.91% +17.24%
- Complexity 2385 3673 +1288
=============================================
Files 1011 999 -12
Lines 24711 24574 -137
Branches 2439 2403 -36
=============================================
+ Hits 8075 12267 +4192
+ Misses 16037 11250 -4787
- Partials 599 1057 +458
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `12.99%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 42.34% +12.99%
- Complexity 2152 3130 +978
=============================================
Files 1010 981 -29
Lines 24536 24036 -500
Branches 2405 2337 -68
=============================================
+ Hits 7201 10178 +2977
+ Misses 16817 13001 -3816
- Partials 518 857 +339
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [406 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `15.67%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 48.35% +15.67%
- Complexity 2385 3547 +1162
=============================================
Files 1011 999 -12
Lines 24711 24556 -155
Branches 2439 2402 -37
=============================================
+ Hits 8075 11874 +3799
+ Misses 16037 11684 -4353
- Partials 599 998 +399
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [357 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `18.36%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 51.04% +18.36%
- Complexity 2385 3659 +1274
=============================================
Files 1011 982 -29
Lines 24711 24130 -581
Branches 2439 2339 -100
=============================================
+ Hits 8075 12316 +4241
+ Misses 16037 10739 -5298
- Partials 599 1075 +476
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [380 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578241334
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: log_count_debug
+ exp: log_count.tagEqual('level', 'DEBUG').sum(['service', 'instance']).increase('PT1M')
+ - name: log_count_error
+ exp: log_count.tagEqual('level', 'ERROR').sum(['service', 'instance']).increase('PT1M')
+
+```
+
+The other metrics generated is `http_response_time`, so that you can configure MAL rules to generate more useful metrics like percentiles.
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: response_time_percentile
+ exp: http_response_time.sum(['le', 'service', 'instance']).increase('PT5M').histogram().histogram_percentile([50,70,90,99])
+```
+
+### Sink
+
+Sinks are the persistent layer of the LAL. By default, all the logs of each filter are persisted into the storage. However, there are some mechanisms that allow you to selectively save some logs, or even drop all the logs after you've extracted useful information, such as metrics.
+
+#### Sampler
+
+Sampler allows you to save the logs in a sampling manner. Currently, 2 sampling strategies are supported, `ratelimit` and `probabilistic`. If multiple samplers are specified, the last one determines the final sampling result, see examples in [Enforcer](#enforcer).
+
+`ratelimit` samples `n` logs at most, in a given duration (e.g. 1 second).
+`probabilistic` samples `n%` logs .
+
+Examples:
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ ratelimit 100.per.second // 100 logs per second
+ }
+ }
+}
+```
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ probabilistic 50.percent // 50% logs
+ }
+ }
+}
+```
+
+#### Dropper
+
+Dropper is a special sink, meaning that all the logs are dropped without any exception. This is useful when you want to drop debugging logs,
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ if (parsed.level == "DEBUG") {
+ dropper {}
+ } else {
+ sampler {
+ // ... configs
+ }
+ }
+ }
+}
+```
+
+or you have multiple filters, some of which are for extracting metrics, only one of them needs to be persisted.
+
+```groovy
+filter { // filter A: this is for persistence
+ // ... parser
+
+ sink {
+ sampler {
+ // .. sampler configs
+ }
+ }
+}
+filter { // filter B:
+ // ... extractors to generate many metrics
+ extractors {
+ metrics {
+ // ... metrics
+ }
+ }
+ sink {
+ dropper {} // drop all logs because they have been saved in "filter A" above.
+ }
+}
+```
+
+#### Enforcer
+
+Enforcer is another special sink that forcibly samples the log, a typical use case of enforcer is when you have configured a sampler and want to save some logs forcibly, for example, to save error logs even if the sampling mechanism is configured.
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ // ... sampler configs
+ }
+ if (parserd["level"] == "ERROR") { // sample error logs even if the sampling strategy is configured
+ enforcer {
+ }
+ }
+ }
Review comment:
I am a little confused about this example, if the data run as a flow, then, no sampled data should be ignored already. Is this meaning, all codes will execute, and sampled is only a flag rather than a `return statement`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578233310
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
Review comment:
MAL was related to receivers, you could see the rule YAMLs existing in different folders, which are controlled by different receivers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `8.02%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 37.37% +8.02%
- Complexity 2152 2301 +149
============================================
Files 1010 831 -179
Lines 24536 20460 -4076
Branches 2405 1934 -471
============================================
+ Hits 7201 7646 +445
+ Misses 16817 12239 -4578
- Partials 518 575 +57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [371 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `18.91%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 51.59% +18.91%
- Complexity 2385 3749 +1364
=============================================
Files 1011 999 -12
Lines 24711 24634 -77
Branches 2439 2392 -47
=============================================
+ Hits 8075 12709 +4634
+ Misses 16037 10826 -5211
- Partials 599 1099 +500
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `20.98%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.33% +20.98%
- Complexity 2152 2999 +847
=============================================
Files 1010 848 -162
Lines 24536 21006 -3530
Branches 2405 2003 -402
=============================================
+ Hits 7201 10574 +3373
+ Misses 16817 9575 -7242
- Partials 518 857 +339
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579650445
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+ - name: example
+ dsl: |
+ filter {
Review comment:
I am feeling, we need a sampler before and after `text` to filter the logs, due to separate different services having different log formats.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `17.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 35.71% -17.57%
+ Complexity 3934 2141 -1793
=============================================
Files 1767 808 -959
Lines 37687 19895 -17792
Branches 4172 1890 -2282
=============================================
- Hits 20081 7106 -12975
+ Misses 16612 12247 -4365
+ Partials 994 542 -452
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1395 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `19.00%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 48.35% +19.00%
- Complexity 2152 3497 +1345
=============================================
Files 1010 981 -29
Lines 24536 24099 -437
Branches 2405 2358 -47
=============================================
+ Hits 7201 11653 +4452
+ Misses 16817 11449 -5368
- Partials 518 997 +479
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [433 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-783253823
Generally good to me, please fix CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.28%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.96% +17.28%
- Complexity 2385 3581 +1196
=============================================
Files 1011 999 -12
Lines 24711 24498 -213
Branches 2439 2396 -43
=============================================
+ Hits 8075 12240 +4165
+ Misses 16037 11242 -4795
- Partials 599 1016 +417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578256911
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
Review comment:
We should update this on the document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578251406
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
Review comment:
> Could we use `parsed.*` as tag's `key`?
Yes, you can use `tags: [(parsed.foo): parsed.bar]` or `tags: ["$parsed.foo": parsed.bar]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `4.39%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 37.07% +4.39%
+ Complexity 2385 2273 -112
============================================
Files 1011 831 -180
Lines 24711 20270 -4441
Branches 2439 1910 -529
============================================
- Hits 8075 7515 -560
+ Misses 16037 12184 -3853
+ Partials 599 571 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `22.64%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 51.99% +22.64%
- Complexity 2152 3752 +1600
=============================================
Files 1010 999 -11
Lines 24536 24617 +81
Branches 2405 2413 +8
=============================================
+ Hits 7201 12799 +5598
+ Misses 16817 10703 -6114
- Partials 518 1115 +597
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [404 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `17.44%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 46.79% +17.44%
- Complexity 2152 2811 +659
=============================================
Files 1010 848 -162
Lines 24536 20944 -3592
Branches 2405 1983 -422
=============================================
+ Hits 7201 9801 +2600
+ Misses 16817 10381 -6436
- Partials 518 762 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `11.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 42.20% -11.08%
+ Complexity 3934 2526 -1408
=============================================
Files 1767 825 -942
Lines 37687 20431 -17256
Branches 4172 1947 -2225
=============================================
- Hits 20081 8623 -11458
+ Misses 16612 11148 -5464
+ Partials 994 660 -334
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579648045
##########
File path: oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.log.analyzer.dsl.spec.sink;
+
+import groovy.lang.Closure;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.AbstractSpec;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.sink.sampler.RateLimitingSampler;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.sink.sampler.Sampler;
+import org.apache.skywalking.oap.log.analyzer.provider.LogAnalyzerModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SamplerSpec extends AbstractSpec {
+ private static final Logger LOGGER = LoggerFactory.getLogger(SamplerSpec.class);
Review comment:
Suggest using annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578257142
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: log_count_debug
+ exp: log_count.tagEqual('level', 'DEBUG').sum(['service', 'instance']).increase('PT1M')
+ - name: log_count_error
+ exp: log_count.tagEqual('level', 'ERROR').sum(['service', 'instance']).increase('PT1M')
+
+```
+
+The other metrics generated is `http_response_time`, so that you can configure MAL rules to generate more useful metrics like percentiles.
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: response_time_percentile
+ exp: http_response_time.sum(['le', 'service', 'instance']).increase('PT5M').histogram().histogram_percentile([50,70,90,99])
+```
+
+### Sink
+
+Sinks are the persistent layer of the LAL. By default, all the logs of each filter are persisted into the storage. However, there are some mechanisms that allow you to selectively save some logs, or even drop all the logs after you've extracted useful information, such as metrics.
+
+#### Sampler
+
+Sampler allows you to save the logs in a sampling manner. Currently, 2 sampling strategies are supported, `ratelimit` and `probabilistic`. If multiple samplers are specified, the last one determines the final sampling result, see examples in [Enforcer](#enforcer).
+
+`ratelimit` samples `n` logs at most, in a given duration (e.g. 1 second).
+`probabilistic` samples `n%` logs .
+
+Examples:
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ ratelimit 100.per.second // 100 logs per second
+ }
+ }
+}
+```
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ probabilistic 50.percent // 50% logs
+ }
+ }
+}
+```
+
+#### Dropper
+
+Dropper is a special sink, meaning that all the logs are dropped without any exception. This is useful when you want to drop debugging logs,
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ if (parsed.level == "DEBUG") {
+ dropper {}
+ } else {
+ sampler {
+ // ... configs
+ }
+ }
+ }
+}
+```
+
+or you have multiple filters, some of which are for extracting metrics, only one of them needs to be persisted.
+
+```groovy
+filter { // filter A: this is for persistence
+ // ... parser
+
+ sink {
+ sampler {
+ // .. sampler configs
+ }
+ }
+}
+filter { // filter B:
+ // ... extractors to generate many metrics
+ extractors {
+ metrics {
+ // ... metrics
+ }
+ }
+ sink {
+ dropper {} // drop all logs because they have been saved in "filter A" above.
+ }
+}
+```
+
+#### Enforcer
+
+Enforcer is another special sink that forcibly samples the log, a typical use case of enforcer is when you have configured a sampler and want to save some logs forcibly, for example, to save error logs even if the sampling mechanism is configured.
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ // ... sampler configs
+ }
+ if (parserd["level"] == "ERROR") { // sample error logs even if the sampling strategy is configured
+ enforcer {
+ }
+ }
+ }
Review comment:
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579650221
##########
File path: oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.log.analyzer.dsl.spec.sink;
+
+import groovy.lang.Closure;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.AbstractSpec;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.sink.sampler.RateLimitingSampler;
+import org.apache.skywalking.oap.log.analyzer.dsl.spec.sink.sampler.Sampler;
+import org.apache.skywalking.oap.log.analyzer.provider.LogAnalyzerModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SamplerSpec extends AbstractSpec {
+ private static final Logger LOGGER = LoggerFactory.getLogger(SamplerSpec.class);
Review comment:
> Suggest using annotation.
Infeasible, the logger name is `log` via annotation, conflict with the `log` property in DSL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `9.09%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 38.44% +9.09%
- Complexity 2152 2398 +246
============================================
Files 1010 848 -162
Lines 24536 20857 -3679
Branches 2405 1978 -427
============================================
+ Hits 7201 8018 +817
+ Misses 16817 12252 -4565
- Partials 518 587 +69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [305 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577670654
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
Review comment:
I think we don't have `tips` in the MAL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **decrease** coverage by `1.20%`.
> The diff coverage is `4.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 29.34% 28.14% -1.21%
+ Complexity 2152 1787 -365
============================================
Files 1010 830 -180
Lines 24536 20046 -4490
Branches 2405 1856 -549
============================================
- Hits 7201 5642 -1559
+ Misses 16817 13981 -2836
+ Partials 518 423 -95
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [442 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `13.63%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 46.31% +13.63%
- Complexity 2385 3410 +1025
=============================================
Files 1011 999 -12
Lines 24711 24452 -259
Branches 2439 2394 -45
=============================================
+ Hits 8075 11324 +3249
+ Misses 16037 12168 -3869
- Partials 599 960 +361
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578252162
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,239 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use LAL to parse, extract, and save the logs, as well as collaborate the logs with traces (by extracting the trace id, segment id and span id) and metrics (by generating metrics from the logs and send them to the meter system).
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed.level
+ // we add a tag called `level` and its value is parsed.level, captured from the regexp above
+ traceId parsed.traceId
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs, and sends the generated metrics to the meter system, you can configure [MAL](mal.md) for further analysis of these metrics. Examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed.serviceName
+ metrics("log_count") {
+ timestamp: parsed.timestamp
+ tags: ["level": parsed.level, "service": parsed.service, "instance": parsed.instance]
+ value: 1
+ }
+ metrics("http_response_time") {
+ timestamp: parsed.timestamp
+ tags: ["status_code": parsed.statusCode, "service": parsed.service, "instance": parsed.instance]
+ value: parsed.duration
+ }
+ }
+ // ...
+}
+```
+
+The extractor above generates a metrics named `log_count`, with tag key `level` and value `1`, after this, you can configure MAL rules to calculate the log count grouping by logging level like this:
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: log_count_debug
+ exp: log_count.tagEqual('level', 'DEBUG').sum(['service', 'instance']).increase('PT1M')
+ - name: log_count_error
+ exp: log_count.tagEqual('level', 'ERROR').sum(['service', 'instance']).increase('PT1M')
+
+```
+
+The other metrics generated is `http_response_time`, so that you can configure MAL rules to generate more useful metrics like percentiles.
+
+```yaml
+# ... other configurations of MAL
+
+metrics:
+ - name: response_time_percentile
+ exp: http_response_time.sum(['le', 'service', 'instance']).increase('PT5M').histogram().histogram_percentile([50,70,90,99])
+```
+
+### Sink
+
+Sinks are the persistent layer of the LAL. By default, all the logs of each filter are persisted into the storage. However, there are some mechanisms that allow you to selectively save some logs, or even drop all the logs after you've extracted useful information, such as metrics.
+
+#### Sampler
+
+Sampler allows you to save the logs in a sampling manner. Currently, 2 sampling strategies are supported, `ratelimit` and `probabilistic`. If multiple samplers are specified, the last one determines the final sampling result, see examples in [Enforcer](#enforcer).
+
+`ratelimit` samples `n` logs at most, in a given duration (e.g. 1 second).
+`probabilistic` samples `n%` logs .
+
+Examples:
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ ratelimit 100.per.second // 100 logs per second
+ }
+ }
+}
+```
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ probabilistic 50.percent // 50% logs
+ }
+ }
+}
+```
+
+#### Dropper
+
+Dropper is a special sink, meaning that all the logs are dropped without any exception. This is useful when you want to drop debugging logs,
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ if (parsed.level == "DEBUG") {
+ dropper {}
+ } else {
+ sampler {
+ // ... configs
+ }
+ }
+ }
+}
+```
+
+or you have multiple filters, some of which are for extracting metrics, only one of them needs to be persisted.
+
+```groovy
+filter { // filter A: this is for persistence
+ // ... parser
+
+ sink {
+ sampler {
+ // .. sampler configs
+ }
+ }
+}
+filter { // filter B:
+ // ... extractors to generate many metrics
+ extractors {
+ metrics {
+ // ... metrics
+ }
+ }
+ sink {
+ dropper {} // drop all logs because they have been saved in "filter A" above.
+ }
+}
+```
+
+#### Enforcer
+
+Enforcer is another special sink that forcibly samples the log, a typical use case of enforcer is when you have configured a sampler and want to save some logs forcibly, for example, to save error logs even if the sampling mechanism is configured.
+
+```groovy
+filter {
+ // ... parser
+
+ sink {
+ sampler {
+ // ... sampler configs
+ }
+ if (parserd["level"] == "ERROR") { // sample error logs even if the sampling strategy is configured
+ enforcer {
+ }
+ }
+ }
Review comment:
> Is this meaning, all codes will execute, and sampled is only a flag rather than a `return statement`?
Right, sampling result is a flag, only when the persistence really happens, the sampling result takes effect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `19.39%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 48.74% +19.39%
- Complexity 2152 3575 +1423
=============================================
Files 1010 999 -11
Lines 24536 24576 +40
Branches 2405 2408 +3
=============================================
+ Hits 7201 11980 +4779
+ Misses 16817 11569 -5248
- Partials 518 1027 +509
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [363 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `16.66%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.34% +16.66%
- Complexity 2385 3556 +1171
=============================================
Files 1011 999 -12
Lines 24711 24488 -223
Branches 2439 2395 -44
=============================================
+ Hits 8075 12083 +4008
+ Misses 16037 11404 -4633
- Partials 599 1001 +402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579649867
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
Review comment:
I am feeling an example in the doc with explanation line by line, should be more friendly. And we don't need to include these in the dist.
Also, these files in `main/resources` would be included in the jar files, rather than real `/config` of dist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `3.18%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 32.53% +3.18%
+ Complexity 2152 2059 -93
============================================
Files 1010 848 -162
Lines 24536 20768 -3768
Branches 2405 1953 -452
============================================
- Hits 7201 6756 -445
+ Misses 16817 13522 -3295
+ Partials 518 490 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [271 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.74%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 51.09% +21.74%
- Complexity 2152 3694 +1542
=============================================
Files 1010 998 -12
Lines 24536 24549 +13
Branches 2405 2388 -17
=============================================
+ Hits 7201 12543 +5342
+ Misses 16817 10938 -5879
- Partials 518 1068 +550
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [388 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-782589797
There is minor adjustments in the docs, please take an overall view of it before reviewing codes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.95%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 51.29% +21.95%
- Complexity 2152 3039 +887
=============================================
Files 1010 848 -162
Lines 24536 21006 -3530
Branches 2405 2003 -402
=============================================
+ Hits 7201 10776 +3575
+ Misses 16817 9375 -7442
- Partials 518 855 +337
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `19.09%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 51.77% +19.09%
- Complexity 2385 3771 +1386
=============================================
Files 1011 999 -12
Lines 24711 24610 -101
Branches 2439 2404 -35
=============================================
+ Hits 8075 12741 +4666
+ Misses 16037 10771 -5266
- Partials 599 1098 +499
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [409 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (1fd5144) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `3.49%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 29.18% -3.50%
============================================
Files 1011 1691 +680
Lines 24711 35417 +10706
Branches 2439 4662 +2223
============================================
+ Hits 8075 10337 +2262
- Misses 16037 24118 +8081
- Partials 599 962 +363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1710 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...6fc30e7](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.90%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.24% +25.90%
- Complexity 2152 3988 +1836
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13668 +6467
+ Misses 16817 9876 -6941
- Partials 518 1195 +677
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [463 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.96%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.30% +25.96%
- Complexity 2152 3990 +1838
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13683 +6482
+ Misses 16817 9854 -6963
- Partials 518 1202 +684
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `14.14%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 43.48% +14.14%
- Complexity 2152 2701 +549
=============================================
Files 1010 848 -162
Lines 24536 20920 -3616
Branches 2405 1980 -425
=============================================
+ Hits 7201 9098 +1897
+ Misses 16817 11118 -5699
- Partials 518 704 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [363 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.76%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.11% +25.76%
- Complexity 2152 3982 +1830
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13635 +6434
+ Misses 16817 9916 -6901
- Partials 518 1188 +670
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [460 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `13.68%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 46.36% +13.68%
- Complexity 2385 3414 +1029
=============================================
Files 1011 999 -12
Lines 24711 24452 -259
Branches 2439 2394 -45
=============================================
+ Hits 8075 11336 +3261
+ Misses 16037 12155 -3882
- Partials 599 961 +362
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `20.66%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 53.34% +20.66%
- Complexity 2385 3870 +1485
=============================================
Files 1011 999 -12
Lines 24711 24648 -63
Branches 2439 2410 -29
=============================================
+ Hits 8075 13149 +5074
+ Misses 16037 10378 -5659
- Partials 599 1121 +522
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [413 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...b921bba](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `9.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 53.28% 43.80% -9.49%
+ Complexity 3934 2378 -1556
============================================
Files 1767 1756 -11
Lines 37687 37253 -434
Branches 4172 4328 +156
============================================
- Hits 20081 16318 -3763
- Misses 16612 19944 +3332
+ Partials 994 991 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| ... and [313 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577619947
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
Review comment:
Speaking of the JSON and YAML, are they going to be flat structure? Such as using `level1.level2...` to represent the hierarchy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r577618651
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
Review comment:
Do we really have default LAL script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `17.44%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 46.79% +17.44%
- Complexity 2152 2811 +659
=============================================
Files 1010 848 -162
Lines 24536 20944 -3592
Branches 2405 1983 -422
=============================================
+ Hits 7201 9801 +2600
+ Misses 16817 10381 -6436
- Partials 518 762 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `26.30%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.65% +26.30%
- Complexity 2152 3982 +1830
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13751 +6550
+ Misses 16817 9784 -7033
- Partials 518 1172 +654
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [477 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.07%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.42% +21.07%
- Complexity 2152 3673 +1521
=============================================
Files 1010 998 -12
Lines 24536 24613 +77
Branches 2405 2412 +7
=============================================
+ Hits 7201 12410 +5209
+ Misses 16817 11159 -5658
- Partials 518 1044 +526
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [425 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578083515
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
Review comment:
How to merge multiple lines into a single one, for example, the error stack scenario?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `14.11%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 46.79% +14.11%
- Complexity 2385 3434 +1049
=============================================
Files 1011 998 -13
Lines 24711 24500 -211
Branches 2439 2380 -59
=============================================
+ Hits 8075 11465 +3390
+ Misses 16037 12057 -3980
- Partials 599 978 +379
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `8.61%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 37.96% +8.61%
- Complexity 2152 2360 +208
============================================
Files 1010 848 -162
Lines 24536 20777 -3759
Branches 2405 1953 -452
============================================
+ Hits 7201 7887 +686
+ Misses 16817 12313 -4504
- Partials 518 577 +59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580032612
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+ - name: example
+ dsl: |
+ filter {
Review comment:
> I am feeling, we need a sampler before and after `text` to filter the logs, due to separate different services having different log formats.
Sampler is targeted on sink (persistent layer), it doesn't mean to serve as an `if` statement, users are free to have `if` statement in the parser
```groovy
filter {
text {
if log.service == "ServiceA" {
text "log format of service A"
} else if log.service == "ServiceB" {
text "log format of service B"
}
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b9af649) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **increase** coverage by `29.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
===========================================
+ Coverage 0.00% 29.35% +29.35%
===========================================
Files 173 1668 +1495
Lines 4239 34984 +30745
Branches 485 4621 +4136
===========================================
+ Hits 0 10268 +10268
- Misses 4239 23765 +19526
- Partials 0 951 +951
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginFinder.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkZpbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...walking/apm/agent/core/plugin/PluginBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkJvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [1662 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...e195519](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `24.41%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 53.76% +24.41%
- Complexity 2152 3900 +1748
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13284 +6083
+ Misses 16817 10276 -6541
- Partials 518 1147 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `25.14%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 54.49% +25.14%
- Complexity 2152 3929 +1777
=============================================
Files 1010 999 -11
Lines 24536 24707 +171
Branches 2405 2419 +14
=============================================
+ Hits 7201 13464 +6263
+ Misses 16817 10083 -6734
- Partials 518 1160 +642
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [469 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `17.31%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.99% +17.31%
- Complexity 2385 3584 +1199
=============================================
Files 1011 999 -12
Lines 24711 24498 -213
Branches 2439 2396 -43
=============================================
+ Hits 8075 12247 +4172
+ Misses 16037 11235 -4802
- Partials 599 1016 +417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `9.60%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 42.28% +9.60%
- Complexity 2385 2598 +213
============================================
Files 1011 848 -163
Lines 24711 20834 -3877
Branches 2439 1987 -452
============================================
+ Hits 8075 8809 +734
+ Misses 16037 11370 -4667
- Partials 599 655 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [302 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `13.61%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 42.95% +13.61%
- Complexity 2152 2653 +501
=============================================
Files 1010 848 -162
Lines 24536 20936 -3600
Branches 2405 2001 -404
=============================================
+ Hits 7201 8994 +1793
+ Misses 16817 11265 -5552
- Partials 518 677 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578199529
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log service name via `log.service`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ traceId parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `traceId`
+
+`traceId` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `segmentId`
+
+`segmentId` extracts the segment ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `spanId`
+
+`spanId` extracts the span ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
+ counter { // whenever the filter is fed with a piece of log, the counter will be increased by one
+ name: "logsCount"
+ tips: "The total count of received logs"
+ tags: ["key1": "value1", "key2": "value2"]
+ }
+ if (parsed["level"] == "ERROR") {
+ counter {
+ // whenever the filter is fed with a piece of log whose level is ERROR, the counter will be increased by one
+ name: "errorLogsCount"
+ tips: "The total count of error logs"
+ tags:
+ ["key1": "value1", "key2": "value2"]
+ }
+ }
+ gauge { // whenever the filter is fed with a piece of log, the gauge will be increased by one
+ name: "whatever"
+ tips: "whatever"
+ tags: ["k1": "v1", "k2": "v2"]
+ }
+ histogram {
+ name: "httpRequestTime"
+ tips: "The time elapsed of the http request"
+ startNanos: parsed["timestamp"]
+ duration: parsed["duration"]
+ }
+ }
+ }
+ // ...
+}
+```
+
+### Sink
+
+Sinks are the persistent layer of the LAL. By default, all the logs of each filter are persisted into the storage. However, there are some mechanisms that allow you to selectively save some logs, or even drop all the logs after you've extracted useful information, such as metrics.
+
+#### Sampler
+
+Sampler allows you to save the logs in a sampling manner. Currently, 2 sampling strategies are supported, `ratelimit` and `probabilistic`.
+
+`ratelimit` samples `n` logs at most, in a given duration (e.g. 1 second).
+`probabilistic` samples `n%` logs .
+
+Examples:
+
+```groovy
+filter {
+ // ... parser
+
+ sampler {
Review comment:
> What happens if I put 2 samplers here?
The last one wins, documented now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **decrease** coverage by `1.10%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 32.67% 31.57% -1.11%
+ Complexity 2385 2010 -375
============================================
Files 1011 830 -181
Lines 24711 20230 -4481
Branches 2439 1908 -531
============================================
- Hits 8075 6388 -1687
+ Misses 16037 13341 -2696
+ Partials 599 501 -98
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (89f04f9) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `26.08%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 55.43% +26.08%
- Complexity 2152 3994 +1842
=============================================
Files 1010 999 -11
Lines 24536 24739 +203
Branches 2405 2422 +17
=============================================
+ Hits 7201 13714 +6513
+ Misses 16817 9813 -7004
- Partials 518 1212 +694
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `5.49%`.
> The diff coverage is `4.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 34.83% +5.49%
Complexity 2152 2152
============================================
Files 1010 831 -179
Lines 24536 20325 -4211
Branches 2405 1923 -482
============================================
- Hits 7201 7081 -120
+ Misses 16817 12710 -4107
- Partials 518 534 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (94d43ec) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `14.07%`.
> The diff coverage is `46.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 43.42% +14.07%
- Complexity 2152 2658 +506
=============================================
Files 1010 848 -162
Lines 24536 20925 -3611
Branches 2405 1983 -422
=============================================
+ Hits 7201 9087 +1886
+ Misses 16817 11146 -5671
- Partials 518 692 +174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `68.42% <68.42%> (ø)` | `4.00 <4.00> (?)` | |
| ... and [313 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578198962
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,191 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
+
+Check the [`default.yaml`](../../../oap-server/server-bootstrap/src/main/resources/lal/default.yaml) for examples.
+
+## Filter
+
+A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters
+to organize their processing logics. Every piece of log will be sent to all filters in an LAL rule. The piece of log sent into the filter is available as property `log` in the LAL, therefore you can access the log level via `log.level`.
+
+### Parser
+
+Parsers are responsible for parsing the raw logs into structured data in SkyWalking for further processing. There are 3
+types of parsers at the moment, namely `json`, `yaml`, and `text`.
+
+When a piece of log is parsed, there is a corresponding property available, called `parsed`, injected by LAL.
+Property `parsed` is typically a map, containing all the fields parsed from the raw logs, for example, if the parser
+is `json` / `yaml`, `parsed` is a map containing all the key-values in the `json` / `yaml`, if the parser is `text`
+, `parsed` is a map containing all the captured groups and their values (for `regexp` and `grok`). See examples below.
+
+#### `json`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `yaml`
+
+<!-- TODO: is structured in the reported (gRPC) `LogData`, not much to do -->
+
+#### `text`
+
+For unstructured logs, there are some `text` parsers for use.
+
+- `regexp`
+
+`regexp` parser uses a regular expression (`regexp`) to parse the logs. It leverages the captured groups of the regexp,
+all the captured groups can be used later in the extractors or sinks.
+
+```groovy
+filter {
+ text {
+ regexp "(?<timestamp>\\d{8}) (?<thread>\\w+) (?<level>\\w+) (?<traceId>\\w+) (?<msg>.+)"
+ // this is just a demo pattern
+ }
+ extractor {
+ tag key: "level", val: parsed["level"]
+ // we add a tag called `level` and its value is parsed["level"], captured from the regexp above
+ tid parsed["traceId"]
+ // we also extract the trace id from the parsed result, which will be used to associate the log with the trace
+ }
+ // ...
+}
+```
+
+- `grok`
+
+<!-- TODO: grok Java library has poor performance, need to benchmark it, the idea is basically the same with `regexp` above -->
+
+### Extractor
+
+Extractors aim to extract metadata from the logs. The metadata can be a service name, a service instance name, an
+endpoint name, or even a trace ID, all of which can be associated with the existing traces and metrics.
+
+- `service`
+
+`service` extracts the service name from the `parsed` result, and set it into the `LogData`, which will be persisted (if
+not dropped) and is used to associate with traces / metrics.
+
+- `instance`
+
+`instance` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `endpoint`
+
+`endpoint` extracts the service instance name from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `tid`
+
+`tid` extracts the trace ID from the `parsed` result, and set it into the `LogData`, which will be
+persisted (if not dropped) and is used to associate with traces / metrics.
+
+- `metrics`
+
+`metrics` extracts / generates metrics from the logs. The supported metrics are `CounterMetrics`, `GaugeMetrics`,
+and `HistogramMetrics`, examples are as follows:
+
+```groovy
+filter {
+ // ...
+ extractor {
+ service parsed["serviceName"]
+ metrics {
Review comment:
> How to get the value for counter/gauge or even more complex histogram(bucket required)
Addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (cdff359) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `17.50%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 35.78% -17.51%
+ Complexity 3934 2144 -1790
=============================================
Files 1767 808 -959
Lines 37687 19884 -17803
Branches 4172 1890 -2282
=============================================
- Hits 20081 7115 -12966
+ Misses 16612 12203 -4409
+ Partials 994 566 -428
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1394 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579668793
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
> I think we should build a new `ImmutableMap` from a `Map`/`HashMap` in building Sample
Correct me if I'm wrong, the only way to build a new `ImmutableMap` from a `Map` is `com.google.common.collect.ImmutableMap#copyOf(java.util.Map<? extends K,? extends V>)`, which needs to copy the entire map entries, does it work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580031707
##########
File path: oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/dsl/spec/sink/sampler/RateLimitingSampler.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.log.analyzer.dsl.spec.sink.sampler;
+
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Setter;
+import lombok.experimental.Accessors;
+
+@Accessors(fluent = true)
+@EqualsAndHashCode(of = {"qps"})
+public class RateLimitingSampler implements Sampler {
+ @Getter
+ @Setter
+ private volatile int qps;
+
+ private final AtomicInteger factor = new AtomicInteger();
+
+ private ScheduledFuture<?> future;
+
+ @Override
+ public RateLimitingSampler start() {
+ future = Executors.newSingleThreadScheduledExecutor()
+ .scheduleAtFixedRate(this::reset, 1, 1, TimeUnit.SECONDS);
Review comment:
> Don't create a thread in every sampler instance, which will cause too many resources.
Fixed
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `17.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 35.71% -17.58%
+ Complexity 3934 2141 -1793
=============================================
Files 1767 808 -959
Lines 37687 19903 -17784
Branches 4172 1905 -2267
=============================================
- Hits 20081 7108 -12973
+ Misses 16612 12254 -4358
+ Partials 994 541 -453
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1395 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `14.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 50.46% 35.91% -14.55%
+ Complexity 3687 2165 -1522
=============================================
Files 1769 808 -961
Lines 37797 19982 -17815
Branches 4156 1898 -2258
=============================================
- Hits 19073 7177 -11896
+ Misses 17740 12253 -5487
+ Partials 984 552 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (c77073e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `13.40%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 42.75% +13.40%
- Complexity 2152 3155 +1003
=============================================
Files 1010 981 -29
Lines 24536 24049 -487
Branches 2405 2337 -68
=============================================
+ Hits 7201 10281 +3080
+ Misses 16817 12899 -3918
- Partials 518 869 +351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `2.23%`.
> The diff coverage is `24.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 31.58% +2.23%
- Complexity 2152 2402 +250
============================================
Files 1010 980 -30
Lines 24536 23763 -773
Branches 2405 2295 -110
============================================
+ Hits 7201 7505 +304
+ Misses 16817 15597 -1220
- Partials 518 661 +143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-6.00)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.81% <0.00%> (-53.19%)` | `0.00 <0.00> (-7.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [380 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r578199399
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -0,0 +1,216 @@
+# Log Analysis Language
+
+Log Analysis Language (LAL) in SkyWalking is essentially a Domain-Specific Language (DSL) to analyze logs. You can use
+LAL to parse, extract, filter, analyze, and save the logs, as well as collaborate the logs with traces, and metrics.
Review comment:
> `parse, extract, filter, analyze, and save` VS `parser, extractor, and sink`. It makes me feel a little inconsistent.
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7b25767) into [master](https://codecov.io/gh/apache/skywalking/commit/1e4a8ee19b1c5d43f93b2c0dea5c6bd92a9e4f83?el=desc) (1e4a8ee) will **decrease** coverage by `13.75%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
- Coverage 53.28% 39.53% -13.76%
+ Complexity 3934 2320 -1614
=============================================
Files 1767 808 -959
Lines 37687 19938 -17749
Branches 4172 1911 -2261
=============================================
- Hits 20081 7882 -12199
+ Misses 16612 11462 -5150
+ Partials 994 594 -400
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1380 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1e4a8ee...cdff359](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `21.55%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 50.90% +21.55%
- Complexity 2152 3686 +1534
=============================================
Files 1010 998 -12
Lines 24536 24549 +13
Branches 2405 2388 -17
=============================================
+ Hits 7201 12496 +5295
+ Misses 16817 10987 -5830
- Partials 518 1066 +548
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [388 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580118815
##########
File path: oap-server/server-bootstrap/src/main/resources/lal/example.yaml
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
Review comment:
> Example is fine, but moving them to `/config-examples` seems a better idea, including the previous `alarm-settings-sample.yml` file, what do you think?
Agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `3.50%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 36.18% +3.50%
+ Complexity 2385 2234 -151
============================================
Files 1011 831 -180
Lines 24711 20263 -4448
Branches 2439 1891 -548
============================================
- Hits 8075 7332 -743
+ Misses 16037 12374 -3663
+ Partials 599 557 -42
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (d76d4f9) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `19.29%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 51.97% +19.29%
- Complexity 2385 3781 +1396
=============================================
Files 1011 999 -12
Lines 24711 24634 -77
Branches 2439 2392 -47
=============================================
+ Hits 8075 12804 +4729
+ Misses 16037 10727 -5310
- Partials 599 1103 +504
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...71be935](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (752a6df) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `6.04%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 38.71% +6.04%
- Complexity 2385 2854 +469
============================================
Files 1011 981 -30
Lines 24711 23821 -890
Branches 2439 2293 -146
============================================
+ Hits 8075 9223 +1148
+ Misses 16037 13834 -2203
- Partials 599 764 +165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [371 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781962773
> > This doc should be ready soon, do you plan to merge this first?
>
> No hurry. The doc should be adjusted (minor) as implemented. Will push codes and the adjusted doc together.
OK, then, you have my supports about this design. No more comment from me, until codes show up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r579668845
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Sample.java
##########
@@ -38,7 +38,7 @@
@Getter
public class Sample {
final String name;
- final ImmutableMap<String, String> labels;
+ final Map<String, String> labels;
Review comment:
Also, using `ImmutableMap` as the type doesn't allow us to use `Collections.unmodifiableMap()` to wrap the map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (ff15040) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `6.75%`.
> The diff coverage is `5.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 32.67% 39.43% +6.75%
- Complexity 2385 2404 +19
============================================
Files 1011 831 -180
Lines 24711 20290 -4421
Branches 2439 1913 -526
============================================
- Hits 8075 8001 -74
+ Misses 16037 11679 -4358
- Partials 599 610 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [302 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `14.71%`.
> The diff coverage is `46.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 44.06% +14.71%
- Complexity 2152 3314 +1162
=============================================
Files 1010 998 -12
Lines 24536 24487 -49
Branches 2405 2386 -19
=============================================
+ Hits 7201 10790 +3589
+ Misses 16817 12783 -4034
- Partials 518 914 +396
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `26.43% <26.43%> (ø)` | `4.00 <4.00> (?)` | |
| [...g/analyzer/provider/LogAnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9Mb2dBbmFseXplck1vZHVsZVByb3ZpZGVyLmphdmE=) | `86.66% <50.00%> (-13.34%)` | `8.00 <1.00> (ø)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `50.87% <50.87%> (ø)` | `7.00 <7.00> (?)` | |
| [...ywalking/oap/log/analyzer/provider/LALConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9MQUxDb25maWdzLmphdmE=) | `63.15% <63.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `65.51% <65.51%> (ø)` | `8.00 <8.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (b2fe66e) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `14.60%`.
> The diff coverage is `7.07%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 29.34% 43.95% +14.60%
- Complexity 2152 2725 +573
=============================================
Files 1010 848 -162
Lines 24536 20934 -3602
Branches 2405 1998 -407
=============================================
+ Hits 7201 9202 +2001
+ Misses 16817 11025 -5792
- Partials 518 707 +189
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...94d43ec](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (7c85768) into [master](https://codecov.io/gh/apache/skywalking/commit/1d4ff667190a6d84d6621c5ea85a07751fe1a446?el=desc) (1d4ff66) will **increase** coverage by `9.73%`.
> The diff coverage is `24.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
+ Coverage 29.34% 39.08% +9.73%
- Complexity 2152 2960 +808
============================================
Files 1010 980 -30
Lines 24536 23913 -623
Branches 2405 2325 -80
============================================
+ Hits 7201 9346 +2145
+ Misses 16817 13747 -3070
- Partials 518 820 +302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ap/log/analyzer/dsl/spec/sink/sampler/Sampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvU2FtcGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/oap/log/analyzer/provider/log/LogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvTG9nQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-6.00)` | |
| [.../provider/log/listener/RecordAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvbGlzdGVuZXIvUmVjb3JkQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `21.81% <0.00%> (-53.19%)` | `0.00 <0.00> (-7.00)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.86% <8.86%> (ø)` | `1.00 <1.00> (?)` | |
| [...zer/dsl/spec/sink/sampler/RateLimitingSampler.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL3NhbXBsZXIvUmF0ZUxpbWl0aW5nU2FtcGxlci5qYXZh) | `12.12% <12.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `16.66% <16.66%> (ø)` | `1.00 <1.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `18.51% <18.51%> (ø)` | `2.00 <2.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `18.75% <18.75%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [403 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [1d4ff66...7c85768](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `13.66%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 46.34% +13.66%
- Complexity 2385 3413 +1028
=============================================
Files 1011 999 -12
Lines 24711 24452 -259
Branches 2439 2394 -45
=============================================
+ Hits 8075 11332 +3257
+ Misses 16037 12159 -3878
- Partials 599 961 +362
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (e54e627) into [master](https://codecov.io/gh/apache/skywalking/commit/85fc4f827c7b8ef32f17aefbecd202c01d9048e1?el=desc) (85fc4f8) will **increase** coverage by `16.67%`.
> The diff coverage is `8.30%`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
=============================================
+ Coverage 32.67% 49.35% +16.67%
- Complexity 2385 3558 +1173
=============================================
Files 1011 999 -12
Lines 24711 24488 -223
Branches 2439 2395 -44
=============================================
+ Hits 8075 12085 +4010
+ Misses 16037 11402 -4635
- Partials 599 1001 +402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/oap/log/analyzer/dsl/Binding.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvQmluZGluZy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/skywalking/oap/log/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvRFNMLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/JsonParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvSnNvblBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/TextParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvVGV4dFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/log/analyzer/dsl/spec/parser/YamlParserSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9wYXJzZXIvWWFtbFBhcnNlclNwZWMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lking/oap/log/analyzer/dsl/spec/sink/SinkSpec.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NpbmtTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [85fc4f8...ff15040](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#issuecomment-781142150
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=h1) Report
> Merging [#6388](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=desc) (0a7f31d) into [master](https://codecov.io/gh/apache/skywalking/commit/bf013fac275da85a5360dfd0c01e3e796777e885?el=desc) (bf013fa) will **decrease** coverage by `6.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6388 +/- ##
============================================
- Coverage 50.46% 43.96% -6.50%
+ Complexity 3687 3213 -474
============================================
Files 1769 976 -793
Lines 37797 24103 -13694
Branches 4156 2374 -1782
============================================
- Hits 19073 10598 -8475
+ Misses 17740 12609 -5131
+ Partials 984 896 -88
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6388/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=footer). Last update [bf013fa...b9af649](https://codecov.io/gh/apache/skywalking/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6388: Introduce log analysis language (LAL)
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6388:
URL: https://github.com/apache/skywalking/pull/6388#discussion_r580243302
##########
File path: apm-dist-es7/src/main/assembly/binary-es7.xml
##########
@@ -59,6 +65,8 @@
<include>zabbix-rules/*.yaml</include>
<include>otel-oc-rules/*</include>
<include>ui-initialized-templates/*</include>
+ <include>lal/*</include>
+ <include>log-mal-rules/*</include>
Review comment:
@wu-sheng these two directories are gone (in git and dist tar) because they are empty, I need to create something like `.gitignore` file in these directories to make `git add` check the directories in, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org