You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 20:29:52 UTC
[GitHub] [beam] kennknowles opened a new issue, #18805: Perfkit runs are always "official" while running them with Jenkins
kennknowles opened a new issue, #18805:
URL: https://github.com/apache/beam/issues/18805
****What is "official" flag?****
"Official" flag is a PerfkitBenchmarker boolean flag that is set in Jenkins. Perfkit uses it to determine whether test results should be treated as official ones. Currently, in the whole Performance Testing Framework it means that such results will be:
- displayed in the Performance Testing Dashboards ([https://apache-beam-testing.appspot.com/explore?dashboard=5755685136498688](https://apache-beam-testing.appspot.com/explore?dashboard=5755685136498688))
- used for detecting anomalies in those dashboards and reporting them to the community (this is work in progress at the time of writing)
****How can Performance tests be run right now?****
Currently, we have two options for running performance tests:
- run them periodically (this is done by Jenkins on master branch 4 times a day)
- trigger them on demand from Pull Request - for example by typing "Run Java TextIO Performance Test" on Github comment in the PR. For now, they also use master for building the code, which is useless in terms of running them in the PR. They should use the branches code instead otherwise it's misguiding for the user and error-prone. This issue is addressed here: https://issues.apache.org/jira/browse/BEAM-4140
****What is the problem?****
We shouldn't mark on demand runs as "official", because those are run to test unmerged code. This will pollute the dashboards with unwanted results on the plots. in the future, when anomaly detection is merged, it will discover false-positive anomalies (based on unmerged code).
****Proposed solution:****
The official flag in Jenkins should be set based on "GIT_BRANCH" environment variable (AFAIK it's out of the box in Jenkins). Only results from master should be official.
Imported from Jira [BEAM-4298](https://issues.apache.org/jira/browse/BEAM-4298). Original Jira may contain additional context.
Reported by: ŁukaszG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn closed issue #18805: Perfkit runs are always "official" while running them with Jenkins
Posted by GitBox <gi...@apache.org>.
Abacn closed issue #18805: Perfkit runs are always "official" while running them with Jenkins
URL: https://github.com/apache/beam/issues/18805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on issue #18805: Perfkit runs are always "official" while running them with Jenkins
Posted by GitBox <gi...@apache.org>.
Abacn commented on issue #18805:
URL: https://github.com/apache/beam/issues/18805#issuecomment-1367456226
obsolete for now. triggered performance test running on PR instead of on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org