You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2021/03/19 12:12:22 UTC

[plc4x] branch develop updated: plc4go: Skip modbus "Single element read request" test case All three of these tests seem to have timing issues were they sometimes run sometimes not

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new daafb92  plc4go: Skip modbus "Single element read request" test case All three of these tests seem to have timing issues were they sometimes run sometimes not
daafb92 is described below

commit daafb924a15f8a48020d5e939296ebe694cf8298
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Mar 19 13:12:08 2021 +0100

    plc4go: Skip modbus "Single element read request" test case
    All three of these tests seem to have timing issues were they sometimes run sometimes not
---
 plc4go/cmd/main/drivers/tests/modbus_driver_test.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plc4go/cmd/main/drivers/tests/modbus_driver_test.go b/plc4go/cmd/main/drivers/tests/modbus_driver_test.go
index 84e045d..5ce6a8e 100644
--- a/plc4go/cmd/main/drivers/tests/modbus_driver_test.go
+++ b/plc4go/cmd/main/drivers/tests/modbus_driver_test.go
@@ -27,7 +27,8 @@ import (
 
 func TestModbusDriver(t *testing.T) {
 	testutils.RunDriverTestsuite(t, modbus.NewDriver(), "assets/testing/protocols/modbus/DriverTestsuite.xml",
-		// TODO: find out why these test fail
+		// TODO: find out why these test fail. It seems like a timing issue because sometimes the work sometimes not
+		"Single element read request",
 		"Multi element read request",
 		"Array element read request",
 	)