You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by th...@apache.org on 2012/03/23 08:06:36 UTC

svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

Author: thomas
Date: Fri Mar 23 07:06:35 2012
New Revision: 1304212

URL: http://svn.apache.org/viewvc?rev=1304212&view=rev
Log:
Bugfix: MoveMetadataToFailureDir should read MoveMetadataFileToFailureDir

Modified:
    oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

Modified: oodt/trunk/crawler/src/main/resources/cmd-line-options.xml
URL: http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/cmd-line-options.xml?rev=1304212&r1=1304211&r2=1304212&view=diff
==============================================================================
--- oodt/trunk/crawler/src/main/resources/cmd-line-options.xml (original)
+++ oodt/trunk/crawler/src/main/resources/cmd-line-options.xml Fri Mar 23 07:06:35 2012
@@ -186,7 +186,7 @@
 			<bean class="org.apache.oodt.cas.crawl.cli.option.handler.CrawlerBeansPropHandler">
 				<property name="properties">
 					<list>
-						<value>MoveMetadataToFailureDir.toDir</value>
+						<value>MoveMetadataFileToFailureDir.toDir</value>
 						<value>MovePushpullMetFileToFailureDir.toDir</value>
 						<value>MoveDataFileToFailureDir.toDir</value>
 					</list>



Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
No worries, bud you are pw0oning it! 

Keep rockin' on...

Cheers,
Chris

On Mar 26, 2012, at 11:40 AM, Thomas Bennett wrote:

> Hey Chris,
> 
> Ooops. Thanks for the pointers.
> 
> Hopefully I'll iron out all the noob mistakes soon enough! I sensed I was missing something hence my email reply with the issue summary.
> 
>> Thanks for this. If this was tied to a JIRA issue, it's always a good practice to ref the JIRA issue
>> in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read.... as the message.
>> Then in JIRA, we can look up all associated SVN commits, via the Subversion Commits pane.
> 
> Yes I've committed code a few times and closed the issue, only then realising my mistake. I'll put a sticky reminder on my monitor! 
> 
>> No biggie, just wanted to pass along. Also, if you haven't had a chance to yet, please remember
>> to update CHANGES.txt with an entry for this fix.
> 
> Will do.
> 
> Cheers,
> Tom


++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

Posted by Thomas Bennett <lm...@gmail.com>.
Hey Chris,

Ooops. Thanks for the pointers.

Hopefully I'll iron out all the noob mistakes soon enough! I sensed I was missing something hence my email reply with the issue summary.

> Thanks for this. If this was tied to a JIRA issue, it's always a good practice to ref the JIRA issue
> in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read.... as the message.
> Then in JIRA, we can look up all associated SVN commits, via the Subversion Commits pane.

Yes I've committed code a few times and closed the issue, only then realising my mistake. I'll put a sticky reminder on my monitor! 

> No biggie, just wanted to pass along. Also, if you haven't had a chance to yet, please remember
> to update CHANGES.txt with an entry for this fix.

Will do.

Cheers,
Tom

Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Hi Tom,

Thanks for this. If this was tied to a JIRA issue, it's always a good practice to ref the JIRA issue
in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read.... as the message.
Then in JIRA, we can look up all associated SVN commits, via the Subversion Commits pane. 

No biggie, just wanted to pass along. Also, if you haven't had a chance to yet, please remember
to update CHANGES.txt with an entry for this fix.

Thanks!

Cheers,
Chris

On Mar 23, 2012, at 12:06 AM, <th...@apache.org> <th...@apache.org> wrote:

> Author: thomas
> Date: Fri Mar 23 07:06:35 2012
> New Revision: 1304212
> 
> URL: http://svn.apache.org/viewvc?rev=1304212&view=rev
> Log:
> Bugfix: MoveMetadataToFailureDir should read MoveMetadataFileToFailureDir
> 
> Modified:
>    oodt/trunk/crawler/src/main/resources/cmd-line-options.xml
> 
> Modified: oodt/trunk/crawler/src/main/resources/cmd-line-options.xml
> URL: http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/cmd-line-options.xml?rev=1304212&r1=1304211&r2=1304212&view=diff
> ==============================================================================
> --- oodt/trunk/crawler/src/main/resources/cmd-line-options.xml (original)
> +++ oodt/trunk/crawler/src/main/resources/cmd-line-options.xml Fri Mar 23 07:06:35 2012
> @@ -186,7 +186,7 @@
> 			<bean class="org.apache.oodt.cas.crawl.cli.option.handler.CrawlerBeansPropHandler">
> 				<property name="properties">
> 					<list>
> -						<value>MoveMetadataToFailureDir.toDir</value>
> +						<value>MoveMetadataFileToFailureDir.toDir</value>
> 						<value>MovePushpullMetFileToFailureDir.toDir</value>
> 						<value>MoveDataFileToFailureDir.toDir</value>
> 					</list>
> 
> 


++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++