You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/03/13 23:50:59 UTC

Re: Review Request: FLUME-1028: Fix build problem

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4323/
-----------------------------------------------------------

(Updated 2012-03-13 22:50:59.021054)


Review request for Flume.


Changes
-------

Actually applies to FLUME-1028 since FLUME-1029 is a duplicate.


Summary (updated)
-------

This patch goes back to Avro 1.6.1 due to the bug found upstream. Since 1.6.1 doesn't support String as a type in a Map, reverting to the original behavior.


This addresses bug FLUME-1028.
    https://issues.apache.org/jira/browse/FLUME-1028


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 4f29f42 
  flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java 540ccf4 
  flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java 3d2dbea 
  flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java 7403aee 
  flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 3ab24b7 
  pom.xml 77aa9d8 

Diff: https://reviews.apache.org/r/4323/diff


Testing
-------

All unit tests pass.


Thanks,

Mike

Re: Review Request: FLUME-1028: Fix build problem

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4323/#review5909
-----------------------------------------------------------

Ship it!


+1

- Arvind


On 2012-03-13 22:50:59, Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4323/
> -----------------------------------------------------------
> 
> (Updated 2012-03-13 22:50:59)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> This patch goes back to Avro 1.6.1 due to the bug found upstream. Since 1.6.1 doesn't support String as a type in a Map, reverting to the original behavior.
> 
> 
> This addresses bug FLUME-1028.
>     https://issues.apache.org/jira/browse/FLUME-1028
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 4f29f42 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java 540ccf4 
>   flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java 3d2dbea 
>   flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java 7403aee 
>   flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 3ab24b7 
>   pom.xml 77aa9d8 
> 
> Diff: https://reviews.apache.org/r/4323/diff
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> 
> 
> Thanks,
> 
> Mike
> 
>

Re: Review Request: FLUME-1028: Fix build problem

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4323/#review5908
-----------------------------------------------------------

Ship it!


- Brock


On 2012-03-13 22:50:59, Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4323/
> -----------------------------------------------------------
> 
> (Updated 2012-03-13 22:50:59)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> This patch goes back to Avro 1.6.1 due to the bug found upstream. Since 1.6.1 doesn't support String as a type in a Map, reverting to the original behavior.
> 
> 
> This addresses bug FLUME-1028.
>     https://issues.apache.org/jira/browse/FLUME-1028
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 4f29f42 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java 540ccf4 
>   flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroLegacy/AvroLegacySource.java 3d2dbea 
>   flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java 7403aee 
>   flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java 3ab24b7 
>   pom.xml 77aa9d8 
> 
> Diff: https://reviews.apache.org/r/4323/diff
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> 
> 
> Thanks,
> 
> Mike
> 
>