You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/11/28 13:19:26 UTC
[PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
amorynan opened a new pull request, #27717:
URL: https://github.com/apache/doris/pull/27717
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1408911832
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +135,29 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(children);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null) {
+ return false;
+ }
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+ ArrayLiteral that = (ArrayLiteral) o;
+ if (that.children.size() != children.size()) {
+ return false;
+ }
Review Comment:
I think Objects.equals make sure the size already! I will just remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831172112
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1408893501
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##########
@@ -218,4 +219,28 @@ public void write(DataOutput out) throws IOException {
Expr.writeTo(e, out);
}
}
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(children);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null) {
+ return false;
+ }
+ if (!(o instanceof MapLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ MapLiteral that = (MapLiteral) o;
+ if (that.children.size() != children.size()) {
+ return false;
+ }
Review Comment:
ditto
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +135,29 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(children);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null) {
+ return false;
+ }
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+ ArrayLiteral that = (ArrayLiteral) o;
+ if (that.children.size() != children.size()) {
+ return false;
+ }
Review Comment:
remove these lines or u need to check children == null first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1407750798
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ ArrayLiteral that = (ArrayLiteral) o;
+ for (int i = 0; i < children.size(); i++) {
Review Comment:
check children.size() equal first to avoid index out of bound
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof ArrayLiteral)) {
Review Comment:
return false if o == null
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##########
@@ -218,4 +218,31 @@ public void write(DataOutput out) throws IOException {
Expr.writeTo(e, out);
}
}
+
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof MapLiteral)) {
Review Comment:
return false if o == null
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##########
@@ -218,4 +218,31 @@ public void write(DataOutput out) throws IOException {
Expr.writeTo(e, out);
}
}
+
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof MapLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ MapLiteral that = (MapLiteral) o;
+ for (int i = 0; i < children.size(); i++) {
Review Comment:
check children.size() equal first to avoid index out of bound
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StructLiteral.java:
##########
@@ -164,4 +164,30 @@ public void checkValueValid() throws AnalysisException {
e.checkValueValid();
}
}
+
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof StructLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ StructLiteral that = (StructLiteral) o;
+ for (int i = 0; i < children.size(); i++) {
Review Comment:
check children.size() equal first to avoid index out of bound
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StructLiteral.java:
##########
@@ -164,4 +164,30 @@ public void checkValueValid() throws AnalysisException {
e.checkValueValid();
}
}
+
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof StructLiteral)) {
Review Comment:
return false if o == null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27717:
URL: https://github.com/apache/doris/pull/27717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1833449763
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831430170
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831460943
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831320247
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1833449993
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1833732445
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 0e1e7b9a6ae9a891a9ff4973d8181196d3697d14, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4902 4649 4660 4649
q2 359 154 157 154
q3 1500 1316 1318 1316
q4 1151 1017 968 968
q5 3266 3251 3223 3223
q6 253 133 133 133
q7 1005 524 563 524
q8 2213 2228 2230 2228
q9 6979 6989 6936 6936
q10 3280 3389 3375 3375
q11 343 225 244 225
q12 381 253 249 249
q13 4830 3860 3836 3836
q14 245 224 215 215
q15 576 534 522 522
q16 443 395 374 374
q17 1028 691 627 627
q18 8159 7818 7540 7540
q19 1549 1546 1543 1543
q20 602 304 315 304
q21 3416 2997 3003 2997
q22 376 303 305 303
Total cold run time: 46856 ms
Total hot run time: 42241 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4630 4574 4572 4572
q2 316 200 233 200
q3 3747 3734 3745 3734
q4 2527 2507 2503 2503
q5 6231 6187 6178 6178
q6 247 123 128 123
q7 2632 2003 1972 1972
q8 3766 3746 3681 3681
q9 9508 9414 9393 9393
q10 4069 4150 4158 4150
q11 651 512 484 484
q12 802 656 624 624
q13 4387 3653 3643 3643
q14 286 247 247 247
q15 586 523 537 523
q16 500 454 502 454
q17 2108 2076 2110 2076
q18 9510 9036 9940 9036
q19 1839 1780 1774 1774
q20 2309 1987 1952 1952
q21 7470 7073 6867 6867
q22 667 558 555 555
Total cold run time: 68788 ms
Total hot run time: 64741 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1833521970
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.41 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17163907690 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831163008
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831269460
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1408655340
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
Review Comment:
i think u could use `Objects.hash` directly
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ ArrayLiteral that = (ArrayLiteral) o;
+ for (int i = 0; i < children.size(); i++) {
Review Comment:
why not use `Objects.equals(children, that.children)` ?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##########
@@ -218,4 +218,31 @@ public void write(DataOutput out) throws IOException {
Expr.writeTo(e, out);
}
}
+
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof MapLiteral)) {
Review Comment:
iunstanceof include null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831429887
run buidall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1833449544
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831601899
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.42 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17101172485 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831390502
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.42 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17099273449 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1408670498
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+
+ ArrayLiteral that = (ArrayLiteral) o;
+ for (int i = 0; i < children.size(); i++) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831168925
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831188917
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27717:
URL: https://github.com/apache/doris/pull/27717#issuecomment-1831320207
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](complextype)fix array/map/struct impl hashcode and equals [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1407751571
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +134,33 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType) type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ int code = 31 * super.hashCode();
+ for (Expr c : children) {
+ code = code + c.hashCode();
+ }
+ return code;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!(o instanceof ArrayLiteral)) {
Review Comment:
return false if o == null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org