[jira] Commented: (MECLIPSE-152) Write .classpath with ordered dependencies [incl. Patch]

["Max Bowsher (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_115515 ] 

Max Bowsher commented on MECLIPSE-152:
--------------------------------------

Please re-open this issue. A sort by artifactId is not sufficient. Part of the reason for desiring sorting is so that the generated classpaths in the plugins own tests are consistent - some of these contain entries which differ only in classifier, so the classifier it is necessary that the classifier be included in the sort criteria.

For a full solution, the sort key should probably include groupId+artifactId+type+classifier - i.e. the criteria applied by Maven in DefaultArtifact.getDependencyConflictId().

> Write .classpath with ordered dependencies [incl. Patch]
> --------------------------------------------------------
>
>                 Key: MECLIPSE-152
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-152
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.2
>         Environment: Windowz XP, eclipse 3.2
>            Reporter: Holger Hoffstätte
>            Assignee: Arnaud Heritier
>             Fix For: 2.5
>
>         Attachments: orderDependencies.patch, orderDependencies.patch
>
>
> Related to my comment in MNG-1412 - I decided to take a quick stab at the eclipse plugin and voilá! Ordered dependencies in the written .classpath. This is only a prototype (my first attempt at maven development) and could serve as basis for other orderings like groupId, transitive nearness etc.
> Initially I wanted to make IdeDependency comparable (similar to MECLIPSE-150 which added proper equals) but having multiple Comparators seemed better for extensibility.
> It worked right away, does exactly what I want (ordering by artifactId) and has minimal impact. I am not familiar with the maven codebase so I hope this is the right place to do the actual ordering before writing; obviously it should observe a property like -DorderDependencies=artifactId or something similar. The patch is against svn r425750 (2006-08-30). Currently no testcase but if someone tells me how to add/read an orderDependencies property I might add one.
> Comments welcome.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira