You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/20 13:41:28 UTC

[GitHub] [skywalking] mrproliu commented on a change in pull request #4546: Provide HTTP parameter in the profiling contet

mrproliu commented on a change in pull request #4546: Provide HTTP parameter in the profiling contet
URL: https://github.com/apache/skywalking/pull/4546#discussion_r395642921
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
 ##########
 @@ -106,9 +107,9 @@
     private final long createTime;
 
     /**
-     * profiling status
+     * profiling data
      */
-    private volatile boolean profiling;
+    private volatile ThreadProfiler profiler;
 
 Review comment:
   Maybe I need to change it to `ProfilingStatus` because we need the status to check the current context is profiling or ready.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services