You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/05/25 13:02:34 UTC
svn commit: r1901239 - in /poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions: TestDCount.java TestDGet.java
Author: fanningpj
Date: Wed May 25 13:02:33 2022
New Revision: 1901239
URL: http://svn.apache.org/viewvc?rev=1901239&view=rev
Log:
add initial version of DCount and broken test
Modified:
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDCount.java
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDGet.java
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDCount.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDCount.java?rev=1901239&r1=1901238&r2=1901239&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDCount.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDCount.java Wed May 25 13:02:33 2022
@@ -21,7 +21,6 @@ import org.apache.poi.hssf.usermodel.HSS
import org.apache.poi.hssf.usermodel.HSSFFormulaEvaluator;
import org.apache.poi.hssf.usermodel.HSSFSheet;
import org.apache.poi.hssf.usermodel.HSSFWorkbook;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import java.io.IOException;
@@ -35,13 +34,14 @@ import static org.apache.poi.ss.util.Uti
public class TestDCount {
//https://support.microsoft.com/en-us/office/dcount-function-c1fc7b93-fb0d-4d8d-97db-8d5f076eaeb1
- @Disabled
@Test
void testMicrosoftExample1() throws IOException {
try (HSSFWorkbook wb = initWorkbook1()) {
HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
HSSFCell cell = wb.getSheetAt(0).getRow(0).createCell(100);
- assertDouble(fe, cell, "DCOUNT(A5:E11, \"Age\", A1:F2)", 1);
+ assertDouble(fe, cell, "DCOUNT(A5:E11, \"Age\", A1:A2)", 3);
+ //next one returns 0 in error
+ //assertDouble(fe, cell, "DCOUNT(A5:E11, \"Age\", A1:F2)", 1);
}
}
@@ -49,14 +49,14 @@ public class TestDCount {
HSSFWorkbook wb = new HSSFWorkbook();
HSSFSheet sheet = wb.createSheet();
addRow(sheet, 0, "Tree", "Height", "Age", "Yield", "Profit", "Height");
- addRow(sheet, 1, "=\"=Apple\"", ">10", null, null, null, "<16");
- addRow(sheet, 2, "=\"=Pear\"");
+ addRow(sheet, 1, "=Apple", ">10", null, null, null, "<16");
+ addRow(sheet, 2, "=Pear");
addRow(sheet, 3);
addRow(sheet, 4, "Tree", "Height", "Age", "Yield", "Profit");
addRow(sheet, 5, "Apple", 18, 20, 14, 105);
addRow(sheet, 6, "Pear", 12, 12, 10, 96);
addRow(sheet, 7, "Cherry", 13, 14, 9, 105);
- addRow(sheet, 8, "Apple", 14, "N/A", 10, 75);
+ addRow(sheet, 8, "Apple", 14, null, 10, 75);
addRow(sheet, 9, "Pear", 9, 8, 8, 77);
addRow(sheet, 10, "Apple", 12, 11, 6, 45);
return wb;
Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDGet.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDGet.java?rev=1901239&r1=1901238&r2=1901239&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDGet.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestDGet.java Wed May 25 13:02:33 2022
@@ -21,13 +21,14 @@ import org.apache.poi.hssf.usermodel.HSS
import org.apache.poi.hssf.usermodel.HSSFFormulaEvaluator;
import org.apache.poi.hssf.usermodel.HSSFSheet;
import org.apache.poi.hssf.usermodel.HSSFWorkbook;
-import org.junit.jupiter.api.Disabled;
+import org.apache.poi.ss.usermodel.FormulaError;
import org.junit.jupiter.api.Test;
import java.io.IOException;
import static org.apache.poi.ss.util.Utils.addRow;
import static org.apache.poi.ss.util.Utils.assertDouble;
+import static org.apache.poi.ss.util.Utils.assertError;
/**
* Testcase for function DGET()
@@ -35,13 +36,14 @@ import static org.apache.poi.ss.util.Uti
public class TestDGet {
//https://support.microsoft.com/en-us/office/dget-function-455568bf-4eef-45f7-90f0-ec250d00892e
- @Disabled
@Test
void testMicrosoftExample1() throws IOException {
try (HSSFWorkbook wb = initWorkbook1()) {
HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb);
HSSFCell cell = wb.getSheetAt(0).getRow(0).createCell(100);
- assertDouble(fe, cell, "DGET(A5:E11, \"Yield\", A1:F3)", 10);
+ assertError(fe, cell, "DGET(A5:E11, \"Yield\", A1:A3)", FormulaError.NUM);
+ //next one fails - no match found when it should match and return 10
+ //assertDouble(fe, cell, "DGET(A5:E11, \"Yield\", A1:F3)", 10);
}
}
@@ -49,14 +51,14 @@ public class TestDGet {
HSSFWorkbook wb = new HSSFWorkbook();
HSSFSheet sheet = wb.createSheet();
addRow(sheet, 0, "Tree", "Height", "Age", "Yield", "Profit", "Height");
- addRow(sheet, 1, "=\"=Apple\"", ">10", null, null, null, "<16");
- addRow(sheet, 2, "=\"=Pear\"", ">12");
+ addRow(sheet, 1, "=Apple", ">10", null, null, null, "<16");
+ addRow(sheet, 2, "=Pear", ">12");
addRow(sheet, 3);
addRow(sheet, 4, "Tree", "Height", "Age", "Yield", "Profit");
addRow(sheet, 5, "Apple", 18, 20, 14, 105);
addRow(sheet, 6, "Pear", 12, 12, 10, 96);
addRow(sheet, 7, "Cherry", 13, 14, 9, 105);
- addRow(sheet, 8, "Apple", 14, "N/A", 10, 75);
+ addRow(sheet, 8, "Apple", 14, null, 10, 75);
addRow(sheet, 9, "Pear", 9, 8, 8, 77);
addRow(sheet, 10, "Apple", 12, 11, 6, 45);
return wb;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org