You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 14:57:18 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8805: ARROW-10725: [Python][Compute] Expose sort options in Python bindings

jorisvandenbossche commented on a change in pull request #8805:
URL: https://github.com/apache/arrow/pull/8805#discussion_r540235330



##########
File path: python/pyarrow/compute.py
##########
@@ -155,7 +157,7 @@ def _handle_options(name, option_class, options, kwargs):
             "Function {!r} expected a {} parameter, got {}"
             .format(name, option_class, type(options)))
 
-    return options
+    return option_class()

Review comment:
       Indeed, and for RecordBatch/Table, you already get a nice error message when providing it empty sort keys.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org