You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/08 06:14:06 UTC
[GitHub] [james-project] chibenwa opened a new pull request #370: JAMES-3432 Upload routes was unstable
chibenwa opened a new pull request #370:
URL: https://github.com/apache/james-project/pull/370
One time out of 25 the uploaded content was altered (Different SHA 256 in
the data store). Several Apache CI builds had been failing because of this.
Investigating this, I found that a piped input stream strategy was not
hitting this pitfall (RectorUtils::toInputStream). I thus incriminate
some weird data races on the Reactor side...
Other areas of the code are likely affected as both the Cassandra and the
S3 blobStores relies on those for streaming (only relied upon for
attachment upload).
Changing the BlobStore API should likely be considered:
```
public interface BlobStore {
Flux<ByteBuffer> read(BucketName bucketName, BlobId blobId);
}
```
Why:
- Supported by both implementation (Cassandra S3)
- Avoids intermediate transformations requiring blocking
operations/dedicated thread resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #370: JAMES-3432 Upload routes test was unstable
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #370:
URL: https://github.com/apache/james-project/pull/370#issuecomment-815576033
https://github.com/linagora/james-project/issues/3896 I believe is related
> Sending 2 images as attachments on Mobile, on the recipient's side, one of them displays lossy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #370: JAMES-3432 Upload routes test was unstable
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #370:
URL: https://github.com/apache/james-project/pull/370#issuecomment-815676213
As weird as it sounds https://github.com/apache/james-project/pull/374 seems to be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa closed pull request #370: JAMES-3432 Upload routes test was unstable
Posted by GitBox <gi...@apache.org>.
chibenwa closed pull request #370:
URL: https://github.com/apache/james-project/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #370: JAMES-3432 Upload routes test was unstable
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #370:
URL: https://github.com/apache/james-project/pull/370#issuecomment-815618961
Performance tests shall be conducted...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #370: JAMES-3432 Upload routes test was unstable
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #370:
URL: https://github.com/apache/james-project/pull/370#issuecomment-815649796
There is an issue with my proposal: it do not handle exception propagation with the piped stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org