You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/07/13 08:08:38 UTC

DO NOT REPLY [Bug 47515] New: Tomcat can't replicate session when it is started.

https://issues.apache.org/bugzilla/show_bug.cgi?id=47515

           Summary: Tomcat can't replicate session when it is started.
           Product: Tomcat 6
           Version: 6.0.18
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Cluster
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: yoshihara.ryuiti@oss.ntt.co.jp
                CC: yoshihara.ryuiti@oss.ntt.co.jp


System
  two Tomcat Server(AP1,AP2)
  Tomcat's version is 6.0.18.
  Replication method is Delta Manager

 I stopped Tomcat of AP1.
 Then, I restarted Tomcat of AP1.
 Then, for AP1, Tomcat's log is as follows.

  Jul 2, 2009 4:51:04 PM
  org.apache.catalina.ha.session.DeltaManager getAllClusterSessions
  WARNING: Manager [/tpcw]: Drop message SESSION-DELTA
  inside GET_ALL_SESSIONS sync phase start date 7/2/09 4:51 PM message date
1/1/70 9:00 AM

  Jul 2, 2009 4:51:04 PM
  org.apache.catalina.ha.session.DeltaManager getAllClusterSessions
  WARNING: Manager [/tpcw]: Drop message SESSION-ACCESSED
  inside GET_ALL_SESSIONS sync phase start date 7/2/09 4:51 PM message date
1/1/70 9:00 AM

 TimeStamp is incorrect when SESSION-DELTA or SESSION-ACCESSED because "1/1/70
9:00 AM" isn't created time of session.
 In this case, AP1's Tomcat may drop all session data.
 As a result, AP1's Tomcat can't replicate session.
 If TimeStamp is updated when update last replicated time, it goes well.

 I made patch.

 DeltaManager's patch.

Index: java/org/apache/catalina/ha/session/DeltaManager.java
===================================================================
--- java/org/apache/catalina/ha/session/DeltaManager.java    (revision 792004 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=792004 ))
+++ java/org/apache/catalina/ha/session/DeltaManager.java    (working copy)
@@ -1162,7 +1162,10 @@
             }

             //update last replicated time
-            if (msg != null)
session.setLastTimeReplicated(System.currentTimeMillis());
+            if (msg != null){
+                session.setLastTimeReplicated(System.currentTimeMillis());
+                msg.setTimestamp(session.getLastTimeReplicated());
+            }
             return msg;
         } catch (IOException x) {
            
log.error(sm.getString("deltaManager.createMessage.unableCreateDeltaRequest",sessionId),
x);

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 47515] Tomcat can't replicate session when it is started.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47515





--- Comment #3 from Ryuichi Yoshihara <yo...@oss.ntt.co.jp>  2009-07-13 18:02:10 PST ---
Created an attachment (id=23973)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23973)
DeltaManager's patch

Sorry, I miss the patch.

This is the patch for DeltaManager.

Best regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 47515] Tomcat can't replicate session when it is started.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47515


Filip Hanik <fh...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




--- Comment #1 from Filip Hanik <fh...@apache.org>  2009-07-13 12:41:22 PST ---
Many thanks, can you please attach the patch as an attachment as line breaks
get inserted into your copy paste

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 47515] Tomcat can't replicate session when it is started.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47515





--- Comment #2 from Ryuichi Yoshihara <yo...@oss.ntt.co.jp>  2009-07-13 17:23:30 PST ---
Created an attachment (id=23972)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23972)
DeltaManager's patch

 Sorry.

 This is the patch for DeltaManager.

 Best regards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 47515] Tomcat can't replicate session when it is started.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47515


Filip Hanik <fh...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Filip Hanik <fh...@apache.org>  2009-07-16 07:12:50 PST ---
Fixed in trunk
Revision 794684
Proposed for backport to 6.0

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org