[GitHub] [hbase] anoopsjohn commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r498601395



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
##########
@@ -115,4 +116,12 @@
    */
   boolean nextRaw(List<Cell> result, ScannerContext scannerContext)
       throws IOException;
+
+  default byte[] getStartRow() {

Review comment:
       We should not be exposing these in this interface. This interface is exposed to CPs possibly allowing to pollute the keys.
   We can add a method which can check whether a full region scan or not. The RegionScannerImpl having ref to Scan instance as well as Region so it can check whether full region scan or not and return boolean




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org