You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/06 01:49:23 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #3001: [Improve][all] change Log to @Slf4j
liugddx opened a new pull request, #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
This PR contains all the log type substitutions, use @SLF4J unified mode.There are no other logical changes here,but it's a big change,so ask the community to review in detail.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1271164543
> Please resolve conflicts.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#discussion_r988609424
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-druid/src/main/java/org/apache/seatunnel/flink/druid/sink/DruidOutputFormat.java:
##########
@@ -179,9 +178,9 @@ private ParallelIndexIOConfig parallelIndexIOConfig() {
null,
new InlineInputSource(this.data.toString()),
new CsvInputFormat(
- Arrays.asList("name", timestampColumn),
+ Arrays.asList("name", timestampColumn),
"|",
- null,
+ null,
Review Comment:
revert？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1271166079
Please waiting the CI complete. I will merge it after CI finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1271423783
Regarding Connctor V1, do we still need to make replacements?For me, it doesn't make much sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1271140642
Please resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#discussion_r988628179
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-druid/src/main/java/org/apache/seatunnel/flink/druid/sink/DruidOutputFormat.java:
##########
@@ -179,9 +178,9 @@ private ParallelIndexIOConfig parallelIndexIOConfig() {
null,
new InlineInputSource(this.data.toString()),
new CsvInputFormat(
- Arrays.asList("name", timestampColumn),
+ Arrays.asList("name", timestampColumn),
"|",
- null,
+ null,
Review Comment:
Done.Thank you for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1271190768
please rerun the CI. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001#issuecomment-1269345398
> LGTM, but there are some unrelated modifications, are you able to restore it? Also, I didn't check if it has been completely replaced
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3001: [Improve][all] change Log to @Slf4j
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #3001:
URL: https://github.com/apache/incubator-seatunnel/pull/3001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org