You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/06 08:14:04 UTC
[GitHub] viirya commented on a change in pull request #23470:
[SPARK-26549][PySpark] Fix for python worker reuse take no effect for Python3
viirya commented on a change in pull request #23470: [SPARK-26549][PySpark] Fix for python worker reuse take no effect for Python3
URL: https://github.com/apache/spark/pull/23470#discussion_r245498932
##########
File path: python/pyspark/worker.py
##########
@@ -446,7 +446,12 @@ def process():
pickleSer._write_with_length((aid, accum._value), outfile)
# check end of stream
- if read_int(infile) == SpecialLengths.END_OF_STREAM:
+ res = read_int(infile)
+ if sys.version >= '3' and res == SpecialLengths.END_OF_DATA_SECTION:
Review comment:
This sounds weird. Why in Python3, there is an additional `SpecialLengths.END_OF_DATA_SECTION`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org