You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/14 18:48:22 UTC
[GitHub] [nifi] mtien-apache opened a new pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
mtien-apache opened a new pull request #4480:
URL: https://github.com/apache/nifi/pull/4480
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Processor properties will show or hide depending on another property that is selected.
For example, if Property A depends on Property B, then Property A should not be shown in the Configure dialog unless a value is selected for Property B._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
scottyaslan commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-686724960
LGTM +1 on the frontend code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-689050584
@markap14 OK to close this for PR 4512. Thanks for the remaining work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-685174161
The front-end part is now working. Still need to make a few backend changes and add unit tests. @scottyaslan @markap14 Can you review? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-674238991
This is pretty neat. There should be tests added for this though, for the processors that were changed etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-688896382
@mtien-apache I opened a PR, #4512, that addresses the remaining work on the backend, such as validation. And adds some unit/integration/system tests. It includes all of your commits as well (some squashed). OK to close this one in favor of 4512?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 closed pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4480:
URL: https://github.com/apache/nifi/pull/4480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4480: NIFI-1121 Show and hide processor properties dependent on another property.
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4480:
URL: https://github.com/apache/nifi/pull/4480#issuecomment-674224900
Thanks @mtien-apache , will review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org