You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:34:03 UTC

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1520: [fix][Connector] fix sql parse table name error

BenJFan commented on pull request #1520:
URL: https://github.com/apache/incubator-seatunnel/pull/1520#issuecomment-1074690035


   > Good job, some little suggestion, we can split the code from line 108 to 121 into a separate method, this method just receive a query string and return the tableName and field. Then it might be easy to add UT.
   > 
   > https://github.com/apache/incubator-seatunnel/blob/72af94eefedca888e96210564f0518db142b48eb/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/source/JdbcSource.java#L108-L121
   
   Thanks for advise. I will do that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org