[GitHub] [griffin] chitralverma commented on a diff in pull request #628: JDBC Connector SQL mode

["chitralverma (via GitHub)" <gi...@apache.org>]

chitralverma commented on code in PR #628:
URL: https://github.com/apache/griffin/pull/628#discussion_r1112052266


##########
griffin-doc/measure/measure-configuration-guide.md:
##########
@@ -547,13 +547,15 @@ List of supported data connectors:
 | Name       | Type     | Description                            | Default Values |
 |:-----------|:---------|:---------------------------------------|:-------------- |
 | database   | `String` | database name                          | default |
+| sql        | `String` | query sql                              | `Empty` |

Review Comment:
   is `sql` mode mutually exclusive to the usual table db mode or does it work with them? this needs to be documented somewhere.
   
   Also how does this work now with the `where` functionality ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org