You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/05/04 09:44:49 UTC

[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4054: ARTEMIS-3759 Add mirror controller address filter support

gemmellr commented on code in PR #4054:
URL: https://github.com/apache/activemq-artemis/pull/4054#discussion_r864642643


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -208,6 +232,13 @@ public void sendMessage(Message message, RoutingContext context, List<MessageRef
          return;
       }
 
+      if (ignoreAddress(context.getAddress(message))) {
+         if (logger.isTraceEnabled()) {
+            logger.trace("server " + server + " is discarding send to excluded address");

Review Comment:
   In addition to the "excluded" comment, for this one I'd also note it should say _which address_ is in play otherwise its not very helpful.



##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -162,6 +172,12 @@ public void createQueue(QueueConfiguration queueConfiguration) throws Exception
          }
          return;
       }
+      if (ignoreAddress(queueConfiguration.getAddress())) {
+         if (logger.isTraceEnabled()) {
+            logger.trace("Skipping create " + queueConfiguration + ", queue address" + queueConfiguration.getAddress() + " is excluded");

Review Comment:
   Given the filter does actually have 'exclusions' and it might not actually be excluded, so much as just not-included, I would reword this to avoid saying it is 'excluded' specifically, but instead something more general like 'doesnt match filter'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org