You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by karup1990 <gi...@git.apache.org> on 2016/08/12 14:15:14 UTC
[GitHub] zeppelin pull request #1328: ZEPPELIN-1324: Make paragraph code selectable w...
GitHub user karup1990 opened a pull request:
https://github.com/apache/zeppelin/pull/1328
ZEPPELIN-1324: Make paragraph code selectable when running
### What is this PR for?
Make paragraph code selectable when running(*PENDING* or *RUNNING* state)
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1324
### How should this be tested?
Try to select, copy, paste the paragraph code, when paragraph is running
### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1324_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1328
----
commit 8d055c9dbaa9d5a6cd4cd05f8a8f9abea216b935
Author: Karup <ka...@outlook.com>
Date: 2016-08-12T14:11:59Z
Make paragraph code selectable when it is running
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1328: ZEPPELIN-1324: Make paragraph code selectable w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1328: ZEPPELIN-1324: Make paragraph code selectable when run...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1328
CI failure is not relevant.
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1328: ZEPPELIN-1324: Make paragraph code selectable when run...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1328
Failure seems unrelated.
@Leemoonsoo @corneadoug This PR is ready for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1328: ZEPPELIN-1324: Make paragraph code selectable when run...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1328
@karup1990 Tested, works great
LGTM after fixing my inline comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1328: ZEPPELIN-1324: Make paragraph code selectable when run...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1328
Using watchers isn't recommended, you can do it in a more simple way.
All that is needed is to do:
* `$scope.editor.setReadOnly($scope.isRunning());` [here](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L2519) and [there](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L93)
* Replace the `disable` from ng-class by a new class that set `opacity: 0.6`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1328: ZEPPELIN-1324: Make paragraph code selectable when run...
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1328
@corneadoug Addressed feedbacks.
Ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---