You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/18 01:19:48 UTC
Re: Review Request 68375: Fixed encoding behavior of
`http::internal::encode(Request)`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 6:19 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Fixed encoding behavior of `http::internal::encode(Request)`.
Repository: mesos
Description (updated)
-------
Fixed encoding behavior of `http::internal::encode(Request)`.
Diffs (updated)
-----
3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
Diff: https://reviews.apache.org/r/68375/diff/2/
Changes: https://reviews.apache.org/r/68375/diff/1-2/
Testing
-------
Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68375: Fixed encoding behavior of
`http::internal::encode(Request)`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/#review207770
-----------------------------------------------------------
Ship it!
Note that at some point we'll also have to escape path segments, fragments, etc. E.g.
https://github.com/golang/go/blob/64f3d75bc288679e9e18cb9513897e7139f3fc3b/src/net/url/url.go#L96-L176
For now, this looks correct since query escaping seems to require all reserved characters to be escaped. However, it will unnecessarily escape some characters in the "unsafe" set from what I can tell.
- Benjamin Mahler
On Aug. 18, 2018, 1:19 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68375/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9168
> https://issues.apache.org/jira/browse/MESOS-9168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed encoding behavior of `http::internal::encode(Request)`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
>
>
> Diff: https://reviews.apache.org/r/68375/diff/2/
>
>
> Testing
> -------
>
> Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>