[GitHub] [airflow] ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor
URL: https://github.com/apache/airflow/pull/7559#discussion_r385118219
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -991,10 +1057,13 @@ def is_alive(self, grace_multiplier=None):
         if grace_multiplier is not None:
             # Accept the same behaviour as superclass
             return super().is_alive(grace_multiplier=grace_multiplier)
-        scheduler_health_check_threshold = conf.getint('scheduler', 'scheduler_health_check_threshold')
+        # The object can be retrieved from the database, so it does not contain all the attributes.
+        self.scheduler_health_check_threshold = conf.getint(
 
 Review comment:
   The comment is helpful, but as a result there's no point storing this as an attribute, a local variable makes more sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services