[GitHub] reminisce commented on a change in pull request #7223: GPU implementation of cast_storage (dense to rsp)

[gi...@git.apache.org]

reminisce commented on a change in pull request #7223: GPU implementation of cast_storage (dense to rsp)
URL: https://github.com/apache/incubator-mxnet/pull/7223#discussion_r130197428
 
 

 ##########
 File path: benchmark/python/cast_storage.py
 ##########
 @@ -23,17 +23,17 @@ def measure_cost(repeat, f, *args, **kwargs):
 
 
 def run_cast_storage_synthetic():
-    def dns_to_csr(m, n, density, ctx, repeat):
+    def dense_to_sparse(m, n, density, ctx, repeat, storage_type):
 
 Review comment:
   We changed all `storage_type` to 'stype` in front-end. Better to keep the term consistent.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services