You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/07/04 14:43:00 UTC

[jira] [Commented] (DRILL-8501) Json Conversion UDF Not Respecting System JSON Options

    [ https://issues.apache.org/jira/browse/DRILL-8501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863057#comment-17863057 ] 

ASF GitHub Bot commented on DRILL-8501:
---------------------------------------

cgivre opened a new pull request, #2921:
URL: https://github.com/apache/drill/pull/2921

   # [DRILL-8501](https://issues.apache.org/jira/browse/DRILL-XXXX): Json Conversion UDF Not Respecting System JSON Options
   
   ## Description
   The `convert_fromJSON()` function was ignoring Drill system configuration variables for reading JSON.  This PR adds support for `allTextMode` and `readNumbersAsDouble` to this function.  Once merged, the `convert_fromJSON()` function will follow the system settings.
   
   I also split one of the unit test files because it had all the UDF tests mixed with NaN tests. 
   
   ## Documentation
   No user facing changes.
   
   ## Testing
   Added unit tests.  




> Json Conversion UDF Not Respecting System JSON Options
> ------------------------------------------------------
>
>                 Key: DRILL-8501
>                 URL: https://issues.apache.org/jira/browse/DRILL-8501
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - JSON
>    Affects Versions: 1.21.2
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.22.0
>
>
> The convert_fromJSON() UDF does not respect the system JSON options of allTextMode and readAllNumbersAsDouble.  
> This PR fixes that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)