You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by jo...@apache.org on 2021/05/06 21:46:38 UTC

[commons-fileupload] branch master updated: FILEUPLOAD-329 - Fix multiples errors fileupload_checks.xml config file

This is an automated email from the ASF dual-hosted git repository.

jochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/master by this push:
     new f2ee201  FILEUPLOAD-329 - Fix multiples errors fileupload_checks.xml config file
     new ace4719  Merge pull request #82 from arturobernalg/feature/FILEUPLOAD-329
f2ee201 is described below

commit f2ee201c39322e73d5cde42e5a0d22754b4def0f
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Wed May 5 18:00:22 2021 +0200

    FILEUPLOAD-329 - Fix multiples errors fileupload_checks.xml config file
---
 src/checkstyle/fileupload_checks.xml | 38 ++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/src/checkstyle/fileupload_checks.xml b/src/checkstyle/fileupload_checks.xml
index 760cfa5..7ef9935 100644
--- a/src/checkstyle/fileupload_checks.xml
+++ b/src/checkstyle/fileupload_checks.xml
@@ -90,28 +90,36 @@
     <!-- Require package Javadoc -->
     <module name="JavadocPackage"/>
 
-    <!-- Allow comments to suppress checks -->
-    <module name="SuppressionCommentFilter"/>
 
-    <module name="SuppressWithNearbyCommentFilter">
-        <property name="commentFormat" value="CHECKSTYLE IGNORE (\w+) FOR NEXT (\d+) LINES?"/>
-        <property name="checkFormat" value="$1"/>
-        <property name="influenceFormat" value="$2"/>
+    <property name="cacheFile" value="${checkstyle.cache.file}"/>
+
+    <!-- Begin Custom for FileUpload -->
+    <module name="LineLength">
+        <property name="max" value="120"/>
+        <property name="ignorePattern" value="^ \* @version .*$"/>
     </module>
 
-    <module name="TreeWalker">
 
-        <property name="cacheFile" value="${checkstyle.cache.file}"/>
+    <module name="TreeWalker">
 
         <!-- Allow comments to suppress checks -->
-        <module name="FileContentsHolder"/>
+        <module name="SuppressionCommentFilter"/>
+
+        <module name="SuppressWithNearbyCommentFilter">
+          <property name="commentFormat" value="CHECKSTYLE IGNORE (\w+) FOR NEXT (\d+) LINES?"/>
+          <property name="checkFormat" value="$1"/>
+          <property name="influenceFormat" value="$2"/>
+        </module>
+
+
+
+        <!-- Allow comments to suppress checks
+        <module name="FileContentsHolder"/>-->
 
         <!-- Checks for Javadoc comments.                     -->
         <!-- See http://checkstyle.sf.net/config_javadoc.html -->
         <module name="JavadocMethod">
           <property name="scope" value="protected"/>
-          <property name="allowUndeclaredRTE" value="true"/>
-          <property name="allowThrowsTagsForSubclasses" value="true"/>
         </module>
         <module name="JavadocType"/>
         <module name="JavadocVariable"/>
@@ -153,11 +161,6 @@
         <module name="RedundantImport"/>
         <module name="UnusedImports"/>
 
-        <!-- Begin Custom for FileUpload -->
-        <module name="LineLength">
-          <property name="max" value="120"/>
-          <property name="ignorePattern" value="^ \* @version .*$"/>
-        </module>
         <!-- End Custom for FileUpload -->
         <module name="MethodLength"/>
         <module name="ParameterNumber"/>
@@ -205,9 +208,6 @@
         <module name="InnerAssignment"/>
         <module name="MagicNumber"/>
         <module name="MissingSwitchDefault"/>
-        <module name="RedundantThrows">
-          <property name="allowSubclasses" value="true"/>
-        </module>
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>