You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/15 15:09:35 UTC
[GitHub] [flink] StefanRRichter commented on a change in pull request #7813:
[FLINK-10712] Support to restore state when using
RestartPipelinedRegionStrategy
StefanRRichter commented on a change in pull request #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7813#discussion_r275408799
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
##########
@@ -73,10 +79,21 @@ public FailoverRegion(
this.executionGraph = checkNotNull(executionGraph);
this.connectedExecutionVertexes = checkNotNull(connectedExecutions);
+ this.tasks = initTasks(connectedExecutionVertexes);
Review comment:
I have one more suggestion that came to my mind from a second look: we could pass in `Map<JobVertexID, ExecutionJobVertex> tasks` directly into the constructor, doing the work of `initTasks` outside of the class before the constructor is invoked. Constructors that only do assignments are typically easier to test and also separates the concern of object construction from the object itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services