You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/27 07:56:26 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1261: HDDS-4031. Run shell tests in CI
adoroszlai opened a new pull request #1261:
URL: https://github.com/apache/hadoop-ozone/pull/1261
## What changes were proposed in this pull request?
1. Add a helper script to run bash test scripts (`*.bats`).
2. Run `bats` part of CI.
https://issues.apache.org/jira/browse/HDDS-4031
## How was this patch tested?
Created failing test at `hadoop-hdds/common/src/test/shell/failing.bats`:
```
@test "fails" {
[[ "123" == "456" ]]
}
@test "err" {
asdfs
}
```
and tested:
```
$ hadoop-ozone/dev-support/checks/bats.sh
...
$ echo $?
1
$ cat target/bats/summary.txt
not ok 1 fails
# (in test file hadoop-hdds/common/src/test/shell/failing.bats, line 24)
# `@test "fails" {' failed
not ok 2 err
# (in test file hadoop-hdds/common/src/test/shell/failing.bats, line 29)
# `asdfs' failed with status 127
# /var/folders/32/sr06nr7123s3bdfsmqsm4pqw0000gn/T/bats-run-70119/bats.70145.src: line 29: asdfs: command not found
$ cat target/bats/failures
2
```
Passing tests (currently only `gc_opts.bat`):
```
1..3
ok 1 Setting Hadoop GC parameters: add GC params for server
ok 2 Setting Hadoop GC parameters: disabled for client
ok 3 Setting Hadoop GC parameters: disabled if GC params are customized
```
https://github.com/adoroszlai/hadoop-ozone/runs/913609741#step:4:4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1261: HDDS-4031. Run shell tests in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1261:
URL: https://github.com/apache/hadoop-ozone/pull/1261#discussion_r462253628
##########
File path: hadoop-ozone/dist/src/test/shell/gc_opts.bats
##########
@@ -14,14 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-
-
#
# Can be executed with bats (https://github.com/bats-core/bats-core)
-# bats gc_opts.bats (FROM THE CURRENT DIRECTORY)
+# bats gc_opts.bats
#
-source ../../shell/hdds/hadoop-functions.sh
+load ../../shell/hdds/hadoop-functions.sh
Review comment:
Previously it required `.bash` extension, but it's fixed in 1.2.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1261: HDDS-4031. Run shell tests in CI
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1261:
URL: https://github.com/apache/hadoop-ozone/pull/1261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1261: HDDS-4031. Run shell tests in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1261:
URL: https://github.com/apache/hadoop-ozone/pull/1261#issuecomment-665629751
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #1261: HDDS-4031. Run shell tests in CI
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #1261:
URL: https://github.com/apache/hadoop-ozone/pull/1261#discussion_r462206110
##########
File path: hadoop-ozone/dev-support/checks/bats.sh
##########
@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+cd "${DIR}/../../.." || exit 1
+
+REPORT_DIR=${OUTPUT_DIR:-"${DIR}/../../../target/bats"}
+mkdir -p "${REPORT_DIR}"
+REPORT_FILE="${REPORT_DIR}/summary.txt"
+
+rm -f "${REPORT_DIR}/output.log"
+
+find * -path '*/src/test/shell/*' -name '*.bats' -print0 \
Review comment:
<discussion-mode:on>
This pattern ("fail at the end") is introduced to execute all the tests even if some of them are failing. It's very useful for long and flaky test runs.
But it's somewhat more complex.
Recently I started to think to use a "fail fast" approach. It can simplify the scripts and we can use `set -e` to be sure we don't ignore any internal errors.
It's not working everywhere, but here it could.
But I am fine with this approach (which is better to create a summary), just sharing my thoughts.
</discussion-mode:on>
##########
File path: hadoop-ozone/dist/src/test/shell/gc_opts.bats
##########
@@ -14,14 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-
-
#
# Can be executed with bats (https://github.com/bats-core/bats-core)
-# bats gc_opts.bats (FROM THE CURRENT DIRECTORY)
+# bats gc_opts.bats
#
-source ../../shell/hdds/hadoop-functions.sh
+load ../../shell/hdds/hadoop-functions.sh
Review comment:
Oh, good to now, that we have it.
##########
File path: .github/workflows/post-commit.yml
##########
@@ -35,6 +35,26 @@ jobs:
- uses: ./.github/buildenv
with:
args: ./hadoop-ozone/dev-support/checks/build.sh
+ bats:
+ runs-on: ubuntu-18.04
+ steps:
+ - uses: actions/checkout@v2
Review comment:
In the future I am planning to improve all the existing tests:
1. With adding name to all the steps
2. Use upper case for the first letter (default for github actions if the name is missing).
This is the same as the others, so I think we can merge it as is.
##########
File path: hadoop-ozone/dist/src/test/shell/gc_opts.bats
##########
@@ -14,14 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-
-
#
# Can be executed with bats (https://github.com/bats-core/bats-core)
-# bats gc_opts.bats (FROM THE CURRENT DIRECTORY)
+# bats gc_opts.bats
#
-source ../../shell/hdds/hadoop-functions.sh
+load ../../shell/hdds/hadoop-functions.sh
Review comment:
Oh, good to now, that we have this command. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org