[GitHub] [incubator-pinot] kishoreg commented on issue #4208: Do not limit number of groups in combine operator (inter-segments)

[GitBox <gi...@apache.org>]

kishoreg commented on issue #4208: Do not limit number of groups in combine operator (inter-segments)
URL: https://github.com/apache/incubator-pinot/pull/4208#issuecomment-492898775
 
 
   Removing the limit is definitely a concern. We don't want one bad query to kill the server with OOM.
   
   I like @mayankshriv  suggestion of dropping bottom x% every time we reach the limit.  Not sure why this would be expensive.
   
    100k limit for group by is already a  big number. is there a use case that is hitting this limit?
   
   Another naive solution would be to set the Intersegment limit to be double the inner segment limit.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org