[GitHub] sdedic commented on a change in pull request #333: Making nb-javac optional

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #333: Making nb-javac optional
URL: https://github.com/apache/incubator-netbeans/pull/333#discussion_r157865104
 
 

 ##########
 File path: java.source.base/src/org/netbeans/api/java/source/SourceUtils.java
 ##########
 @@ -198,39 +199,6 @@ public static TypeMirror getBound(WildcardType wildcardType) {
      */
     public static List<? extends Completion> getAttributeValueCompletions(CompilationInfo info, Element element, AnnotationMirror annotation, ExecutableElement member, String userText) {
         List<Completion> completions = new LinkedList<>();
-        if (info.getPhase().compareTo(Phase.ELEMENTS_RESOLVED) >= 0) {
-            String fqn = ((TypeElement) annotation.getAnnotationType().asElement()).getQualifiedName().toString();
-            Iterable<? extends Processor> processors = info.impl.getJavacTask().getProcessors();
-            if (processors != null) {
-                for (Processor processor : processors) {
-                    boolean match = false;
-                    for (String sat : processor.getSupportedAnnotationTypes()) {
-                        if ("*".equals(sat)) { //NOI18N
-                            match = true;
-                            break;
-                        } else if (sat.endsWith(".*")) { //NOI18N
-                            sat = sat.substring(0, sat.length() - 1);
-                            if (fqn.startsWith(sat)) {
-                                match = true;
-                                break;
-                            }
-                        } else if (fqn.equals(sat)) {
-                            match = true;
-                            break;
-                        }
-                    }
-                    if (match) {
-                        try {
-                            for (Completion c : processor.getCompletions(element, annotation, member, userText)) {
-                                completions.add(c);
-                            }
-                        } catch (Exception e) {
-                            Logger.getLogger(processor.getClass().getName()).log(Level.INFO, e.getMessage(), e);
-                        }
-                    }
-                }
-            }
-        }
         return completions;
 
 Review comment:
   Removed with no replacement ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists