You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/01 06:09:15 UTC

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #328: test: add e2e test cases for limit-count plugin

tokers opened a new pull request #328:
URL: https://github.com/apache/apisix-ingress-controller/pull/328


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #328: test: add e2e test cases for limit-count plugin

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #328:
URL: https://github.com/apache/apisix-ingress-controller/pull/328#issuecomment-811671141


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=h1) Report
   > Merging [#328](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=desc) (1552db1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/06e2b35bccbf62a9d7a1d0e2680eb9a71be78cae?el=desc) (06e2b35) will **decrease** coverage by `0.48%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 1552db1 differs from pull request most recent head 566e705. Consider uploading reports for the commit 566e705 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #328      +/-   ##
   ==========================================
   - Coverage   42.65%   42.17%   -0.49%     
   ==========================================
     Files          40       39       -1     
     Lines        3418     3417       -1     
   ==========================================
   - Hits         1458     1441      -17     
   - Misses       1801     1815      +14     
   - Partials      159      161       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `28.44% <0.00%> (-5.97%)` | :arrow_down: |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `41.29% <0.00%> (-1.94%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=footer). Last update [06e2b35...566e705](https://codecov.io/gh/apache/apisix-ingress-controller/pull/328?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] gxthrj merged pull request #328: test: add e2e test cases for limit-count plugin

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #328:
URL: https://github.com/apache/apisix-ingress-controller/pull/328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org