You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/09/08 03:20:21 UTC

[GitHub] spark pull request #22353: [SPARK-25357][SQL] Abbreviated simpleString in Da...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22353#discussion_r216119211
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ---
    @@ -54,7 +54,7 @@ trait DataSourceScanExec extends LeafExecNode with CodegenSupport {
       override def simpleString: String = {
         val metadataEntries = metadata.toSeq.sorted.map {
           case (key, value) =>
    -        key + ": " + StringUtils.abbreviate(redact(value), 100)
    --- End diff --
    
    How about parameterizing the second value as a new `SQLConf`? Or, defining `verboseString`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org