You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/08 18:11:56 UTC
[GitHub] [solr] madrob opened a new pull request #614: SOLR-15965 Use proper signatures for SolrAuth
madrob opened a new pull request #614:
URL: https://github.com/apache/solr/pull/614
https://issues.apache.org/jira/browse/SOLR-15965
This is a draft of what the code _could_ look like in 9.0 if we want to maintain backwards compatibility along the full 9x line. Alternatively, the majority of this code could go to 8.11.2 and only the "V2" portions of this code would make it into 9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #614:
URL: https://github.com/apache/solr/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #614:
URL: https://github.com/apache/solr/pull/614#issuecomment-1032964503
I don't know why precommit failed on this building the ref guide with broken links, the link appears to work for me locally when I build it... @ctargett any ideas? Alternatively, we can wait until Antora comes in and then I'll redo the content anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #614:
URL: https://github.com/apache/solr/pull/614#discussion_r802090968
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -53,7 +53,11 @@ SolrCloud doesn't support that but may sometime.
* SOLR-14702: All references to "master" and "slave" were replaced in the code with "leader" and "follower".
This includes API calls for the replication handler and metrics.
-For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-15965: Internode communication secured by PKI Authentication has changed formats. To maintain compatability, you will need to either:
+** Upgrade the cluster to 8.11.2 or newer before proceeding to 9.0
+** Set system properties `solr.pki.sendVersion=v1` and `solr.pki.acceptVersions=v1,v2` on the upgraded nodes. After the whole cluster has been upgraded, you can optionally remove them and perform an additional rolling restart to reject requests coming in via the old format. For more information, see <<authentication-and-authorization-plugins.adoc#_pkiauthenticationplugin,PKI Authentication Plugin>>.
Review comment:
🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #614:
URL: https://github.com/apache/solr/pull/614#discussion_r804320074
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -53,7 +53,11 @@ SolrCloud doesn't support that but may sometime.
* SOLR-14702: All references to "master" and "slave" were replaced in the code with "leader" and "follower".
This includes API calls for the replication handler and metrics.
-For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-15965: Internode communication secured by PKI Authentication has changed formats. To maintain compatability, you will need to either:
+** Upgrade the cluster to 8.11.2 or newer before proceeding to 9.0
Review comment:
I tried making the upgrade instructions more explicit. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ctargett commented on a change in pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #614:
URL: https://github.com/apache/solr/pull/614#discussion_r801998118
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -53,7 +53,11 @@ SolrCloud doesn't support that but may sometime.
* SOLR-14702: All references to "master" and "slave" were replaced in the code with "leader" and "follower".
This includes API calls for the replication handler and metrics.
-For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-15965: Internode communication secured by PKI Authentication has changed formats. To maintain compatability, you will need to either:
+** Upgrade the cluster to 8.11.2 or newer before proceeding to 9.0
+** Set system properties `solr.pki.sendVersion=v1` and `solr.pki.acceptVersions=v1,v2` on the upgraded nodes. After the whole cluster has been upgraded, you can optionally remove them and perform an additional rolling restart to reject requests coming in via the old format. For more information, see <<authentication-and-authorization-plugins.adoc#_pkiauthenticationplugin,PKI Authentication Plugin>>.
Review comment:
The link format here is what's causing your precommit to fail. Our settings remove the asciidoctor default of inserting `_` before anchors, so all you need is `#pkiauthenticationplugin` without the underscore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on a change in pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
tflobbe commented on a change in pull request #614:
URL: https://github.com/apache/solr/pull/614#discussion_r802321380
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -53,7 +53,11 @@ SolrCloud doesn't support that but may sometime.
* SOLR-14702: All references to "master" and "slave" were replaced in the code with "leader" and "follower".
This includes API calls for the replication handler and metrics.
-For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+For rolling upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-15965: Internode communication secured by PKI Authentication has changed formats. To maintain compatability, you will need to either:
+** Upgrade the cluster to 8.11.2 or newer before proceeding to 9.0
Review comment:
I'm guessing we'll want 8.11.2 to default to `solr.pki.sendVersion=v1` and `solr.pki.acceptVersions=v1,v2` to support rolling upgrades from versions <= 8.11.1, right? if that's the case, even upgrading from 8.11.2 may require setting `solr.pki.acceptVersions=v1,v2` unless the user has already upgraded to v2 explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #614: SOLR-15965 Use proper signatures for SolrAuth
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #614:
URL: https://github.com/apache/solr/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org